Skip to content

Fix broken link on p5.js website page for "Our Focus on Access" #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iamniky opened this issue Sep 6, 2024 · 4 comments
Closed

Fix broken link on p5.js website page for "Our Focus on Access" #513

iamniky opened this issue Sep 6, 2024 · 4 comments
Assignees
Labels
Bug Something isn't working

Comments

@iamniky
Copy link

iamniky commented Sep 6, 2024

Most appropriate sections of the p5.js website?

Home

What is your operating system?

Windows

Web browser and version

Firefox v130.0, though would affect all.

Actual Behavior

When users visit the URL https://p5js.org/contribute/access/ and click on the hyperlink that is labeled "2019 Contributors Conference", they are met with a 404 error page:

Screenshot 2024-09-06 012317

Screenshot 2024-09-06 012406

When users visit the URL https://p5js.org/contribute/access/ and click on the hyperlink that is labeled "p5.js Access Day 2022", they are met with a 404 error page:

Screenshot 2024-09-06 012745

Screenshot 2024-09-06 012842

Expected Behavior

We expect that when the users click the hyperlink labeled "2019 Contributors Conference", they are taken to a page with information regarding the 2019 Contributors Conference.

We expect that when the users click the hyperlink labeled "p5.js Access Day 2022", they are taken to a page with information regarding p5.js Access Day 2022.

Steps to reproduce

Steps:

  1. Go to https://p5js.org/contribute/access/
  2. Click on respective links (listed in table below).
  3. Get a 404 error.

Solution:

Replace listed broken links to the correct links.

Source link text: Current link: Suggested link:
2019 Contributors Conference https://p5js.org/community/contributors-conference-2019.html https://p5js.org/events/contributors-conference-2019/
p5.js Access Day 2022 https://p5js.org/community/p5js-access-day-2022.html https://p5js.org/events/p5js-access-day-2022/

Would you like to work on the issue?

Yes, I'd like to work on the issue.

@iamniky iamniky added the Bug Something isn't working label Sep 6, 2024
@shourysingh07
Copy link
Contributor

I'd like to work on the issue.

@Qianqianye
Copy link
Collaborator

Thanks @iamniky for reporting the bug. To share some context, the contribute pages on p5js.org website are built directly from p5.js library repo contributor_docs folder, using a script. So if we want to make changes, we will edit the docs in p5.js library repo contributor_docs folder.

The p5.js Access Day 2022 link is already fixed in this commit within p5.js library repo.

Hi @shourysingh07, if you are interested in working on this issue, please feel free to open a PR within p5.js library repo, and fix the 2019 Contributors Conference link to https://p5js.org/events/contributors-conference-2019. After it's fixed, I will run the script npm run build:contributor-docs to build the page based on the updated doc. Thank you!

@shourysingh07
Copy link
Contributor

Thank You @Qianqianye ! I've opened a pull request within p5.js library repo.

Here is the PR Link.

@Qianqianye
Copy link
Collaborator

Closing this issue since it's fixed in PR #7255 in p5.js repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants