Skip to content

Commit aeda6d2

Browse files
authored
Merge pull request #5764 from limzykenneth/gsod-contributor-docs
GSoD Contributor Docs Editorial Changes
2 parents db02625 + 00d129d commit aeda6d2

12 files changed

+434
-40
lines changed

contributor_docs/README.md

+47-6
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,54 @@
22

33
# 🌸 Welcome! 🌺
44

5-
Thanks for your interest in contributing to p5.js! Our community values contributions of all forms and seeks to expand the meaning of the word "contributor" as far and wide as possible. It includes documentation, teaching, writing code, making art, writing, design, activism, organizing, curating, or anything else you might imagine. [Our community page](https://p5js.org/community/#contribute) gives an overview of some different ways to get involved and contribute. For technical contributions, read on to get started.
5+
Thanks for your interest in contributing to p5.js! Our community values contributions of all forms and seeks to expand the meaning of the word "contributor" as far and wide as possible. It includes documentation, teaching, writing code, making art, writing, design, activism, organizing, curating, or anything else you might imagine. [Our community page](https://p5js.org/community/#contribute) gives an overview of some different ways to get involved and contribute.
66

7-
This project follows the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. Add yourself to the [readme](https://github.com/processing/p5.js/blob/main/README.md#contributors) by following the [instructions here](https://github.com/processing/p5.js/issues/2309)! Or comment in the [GitHub issues](https://github.com/processing/p5.js/issues) with your contribution and we'll add you. The contributor docs are published on p5.js [website](https://p5js.org/contributor-docs/#/), and hosted on p5.js [GitHub repository](https://github.com/processing/p5.js/tree/main/contributor_docs).
7+
This project follows the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. We use the @all-contributors bot to handle adding people to the README.md file. You can ask @all-contributors bot to add you in an issue or PR comment like so:
8+
```
9+
@all-contributors please add @[your github handle] for [your contribution type]
10+
```
11+
You can find relevant contribution type [here](https://allcontributors.org/docs/en/emoji-key). Although we will usually automatically add you to the contributor list using the bot after merging your PR. The contributor docs are published on p5.js [website](https://p5js.org/contributor-docs/#/), and hosted on p5.js [GitHub repository](https://github.com/processing/p5.js/tree/main/contributor_docs).
12+
13+
# Before Contributing
14+
Contributing to p5.js should be a stress free experience and we welcome contributions of all levels, whether you are just fixing a small typo in the documentation or refactoring complex 3D rendering functionalities. However there are just a few things you should be familiar with before starting your contribution.
15+
16+
First, please have a read through our [community statement](https://p5js.org/community/).
17+
18+
Next, we are currently prioritizing work that expands access (inclusion and accessibility) to p5.js! See [our access statement](./access.md) for more details.
19+
20+
# Get Started
21+
Now you are ready to start contributing to p5.js! There are many ways to get started with contributing to p5.js and many reasons to do so. For the purpose of this documentation, we will split contributions roughly into two categories.
22+
- Contributions that directly deals with the source code (including documentation)
23+
- Contributions that directly deals with the source code very little or not at all
24+
25+
Depending on what kind of contribution you are making to p5.js, please read on to the relevant section of this documentation.
826

9-
# Prioritizing access
27+
## Source code contribution
28+
For a typical contribution to the p5.js or p5.js-website repository, we will follow the following steps:
29+
1. Open an issue
30+
2. Discuss
31+
3. Approved for opening a Pull Request (PR)
32+
4. Make necessary changes
33+
5. Open a PR
34+
6. Discuss
35+
7. Approved and merged
1036

11-
We are prioritizing work that expands access (inclusion and accessibility) to p5.js! See [our access statement](./access.md) for more details.
37+
Head over to [this link](./contributor_guidelines.md) where you will be guided one step at a time on how to navigate the steps above, or you can also use the table of contents on the same page to skip to a relevant part you need a refresher on.
38+
39+
Most of the time we will stick with this workflow quite strictly and, especially if you have contributed to other projects before, it may feel like there are too many hoops to jump through for what may be a simple contribution. However, the steps above are aimed to make it easy for you as a contributor and for stewards/maintainers to contribute meaningfully, while also making sure that you won't be spending time working on things that may not be accepted for various reasons. The steps above will help ensure that any proposals or fixes are adequately discussed and considered before any work begin, and often this will actually save you (and the steward/maintainer) time because the PR that would need additional fixing after review, or outright not accepted, would happen less often as a result.
40+
41+
We see contributing to p5.js as a learning opportunity and we don't measure sucess by only looking at the volume of contributions we received. There is no time limit on how long it takes you to complete a contribution, so take your time and work at your own pace. Ask for help from any of the stewards or maintainers if you need them and we'll try our best to support you.
42+
43+
## Non-source code contribution
44+
There are many more ways to contribute to p5.js through non-source code contribution than can be exhaustively list here, some of the ways may also involve working with some of the p5.js repositories (such as adding example, writing tutorial for the website, etc). Depending on what the planned contribution is, we may be able to support you in different ways so do reach out to us via any channel available to you (email, social media, Discourse forum, Discord, etc).
45+
46+
## Stewards and maintainers
47+
This section links to different topics related to the general maintenance of p5.js' repositories.
48+
- Responding to issues and reviewing PRs
49+
- How the library is built
50+
- Releasing a new version
51+
52+
---
1253

1354
# Where our code lives
1455

@@ -17,8 +58,8 @@ The overarching p5.js project includes some repositories other than this one:
1758
- **[p5.js](https://github.com/processing/p5.js)**: This repository contains the source code for the p5.js library. The [user-facing p5.js reference manual](https://p5js.org/reference/) is also generated from the [JSDoc](https://jsdoc.app/) comments included in this source code. It is maintained by [Qianqian Ye](https://github.com/qianqianye) and a group of [stewards](https://github.com/processing/p5.js#stewards).
1859
- **[p5.js-website](https://github.com/processing/p5.js-website)**: This repository contains most of the code for the [p5.js website](http://p5js.org), with the exception of the reference manual. It is maintained by [Qianqian Ye](https://github.com/qianqianye), [Kenneth Lim](https://github.com/limzykenneth), and a group of [stewards](https://github.com/processing/p5.js-website#stewards).
1960
- **[p5.js-sound](https://github.com/processing/p5.js-sound)**: This repository contains the p5.sound.js library. It is maintained by [Jason Sigal](https://github.com/therewasaguy).
20-
- **[p5.js-web-editor](https://github.com/processing/p5.js-web-editor)**: This repository contains the source code for the [p5.js web editor](https://editor.p5js.org). It is maintained by [Cassie Tarakajian](https://github.com/catarak). Note that the older [p5.js editor](https://github.com/processing/p5.js-editor) is now deprecated.
21-
61+
- **[p5.js-web-editor](https://github.com/processing/p5.js-web-editor)**: This repository contains the source code for the [p5.js web editor](https://editor.p5js.org). It is maintained by [Cassie Tarakajian](https://github.com/catarak).
62+
- Other add-on libraries not listed above usually have their own repository and maintainers and are not maintained by the p5.js project directly.
2263

2364

2465
# Repository File Structure
File renamed without changes.

contributor_docs/contributing_documentation.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# Contributing Documentation
2+
13
Documentation is essential for new learners and experienced programmers alike. It helps make our community inclusive by extending a friendly hand to those who are less familiar with p5.js. It also helps us find the bugs and issues with the code itself, because we test and try things out as we document.
24

35
There are several ways to contribute to documentation:
@@ -31,6 +33,3 @@ While the examples in the reference are meant to be very simplistic snippets of
3133
* All discussion happens on github issues, so there's no slack/gitter/etc channel you need to join.
3234
* Add your name to the [contributors list](https://github.com/processing/p5.js#contributors) in the readme.md file! Instructions [here](https://github.com/processing/p5.js/issues/2309).
3335
* And of course, if you're more of a bug fixer kind of person, feel free to jump into any of the [issues](https://github.com/processing/p5.js/issues)!
34-
35-
Welcome! We're so glad you're here!
36-
❤️ the p5.js community

0 commit comments

Comments
 (0)