Merge pull request #7495 from processing/fix/closed-curves

Fix closed curves having extra loops

Author: davepagurek

src/shape/custom_shapes.js

@@ -395,7 +395,7 @@ class SplineSegment extends Segment {
       points.unshift(prevVertex);
       points.push(this.vertices.at(-1));
     } else if (this._splineProperties.ends === constants.JOIN) {
-      points.unshift(this.vertices.at(-1), prevVertex);
+      points.unshift(this.vertices.at(-1));
       points.push(prevVertex, this.vertices.at(0));
     }
 

test/unit/visual/cases/shapes.js

@@ -150,6 +150,16 @@ visualSuite('Shape drawing', function() {
         screenshot();
       });
 
+      visualTest('Drawing simple closed curves', function(p5, screenshot) {
+        setup(p5);
+        p5.beginShape();
+        p5.splineVertex(10, 10);
+        p5.splineVertex(15, 40);
+        p5.splineVertex(40, 35);
+        p5.endShape(p5.CLOSE);
+        screenshot();
+      });
+
       visualTest('Drawing with curves with tightness', function(p5, screenshot) {
         setup(p5);
         p5.splineProperty('tightness', -1);

test/unit/visual/screenshots/Shape drawing/2D mode/Drawing closed curves/000.png

@@ -0,0 +1,3 @@
+{
+  "numScreenshots": 1
+}

test/unit/visual/screenshots/Shape drawing/2D mode/Drawing simple closed curves/000.png

@@ -0,0 +1,3 @@
+{
+  "numScreenshots": 1
+}