Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly Error Messaging for unsupported browsers #657

Closed
workergnome opened this issue May 28, 2015 · 4 comments
Closed

Friendly Error Messaging for unsupported browsers #657

workergnome opened this issue May 28, 2015 · 4 comments

Comments

@workergnome
Copy link
Contributor

As part of our browser detection, we have discovered the desire to display to viewers of p5.js sketches messaging about used features that are not supported by their browser.

We would like these messages to be user-facing, to be able to be disabled by the developer, to have their text have friendly defaults, and to have the messaging customizable by the developer.

We should consider how to detect usage of a feature (webgl, web audio, etc) by a p5.js sketch.

An initial suggestion was to overlay a DOM element over the sketch, that fades out over time.

Suggestions? Discussions?

@kadamwhite
Copy link
Contributor

Sounds like a good plan! Initial thoughts :

  • an overlay sounds good, but the canvas could be a lot of sizes -- possibly better to have it fixed to the viewport instead
  • should we provide internationalization for the default messages? I'm inclined to think that letting developers set their own is sufficient, but wanted to think out loud to see what everyone else thought

@crhallberg
Copy link

Is the idea that you'd an overlay if your browser doesn't support a feature at all or only when that feature is used in the sketch being run?

@workergnome
Copy link
Contributor Author

pinging @therewasaguy, who proposed the initial idea.

@lmccart
Copy link
Member

lmccart commented Oct 4, 2015

aggregated into #971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants