fix: Terminal component can leak observers

starpit · starpit · commit 1233e379553e · 2022-09-16T15:36:02.000-04:00
diff --git a/plugins/plugin-codeflare/src/components/Terminal.tsx b/plugins/plugin-codeflare/src/components/Terminal.tsx
@@ -188,6 +188,7 @@ export default class XTerm extends React.PureComponent<Props, State> {
       }
     })
     observer.observe(xtermContainer)
+    this.cleaners.push(() => observer.disconnect())
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,7 @@ export default class XTerm extends React.PureComponent<Props, State> {`
`188`	`188`	`}`
`189`	`189`	`})`
`190`	`190`	`observer.observe(xtermContainer)`
	`191`	`+ this.cleaners.push(() => observer.disconnect())`
`191`	`192`	`}`
`192`	`193`
`193`	`194`	`/**`