Skip to content

Commit 21297d6

Browse files
committed
fix: terminal does not refresh if only noninteractive bit changed
1 parent cb57f26 commit 21297d6

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Diff for: plugins/plugin-codeflare/src/controller/terminal.tsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,10 @@ export class TaskTerminal extends React.PureComponent<Props, State> {
153153
this.setState({ guidebook, ifor: true, noninteractive: false })
154154

155155
public static getDerivedStateFromProps(props: Props, state: State) {
156-
if (props.defaultGuidebook && state.guidebook !== props.defaultGuidebook) {
156+
if (
157+
props.defaultGuidebook &&
158+
(state.guidebook !== props.defaultGuidebook || props.defaultNoninteractive !== state.noninteractive)
159+
) {
157160
return {
158161
ifor: false,
159162
guidebook: props.defaultGuidebook,

0 commit comments

Comments
 (0)