Skip to content

Commit 37738b0

Browse files
committed
chore: rename main UI component TaskTerminal -> WorkloadDesigner
we were already calling it that in src/index, i.e. the exported API of plugin-codeflare
1 parent 3426500 commit 37738b0

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

Diff for: plugins/plugin-client-default/notebooks/hello.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ execute: now
1313
outputOnly: true
1414
maximize: true
1515
---
16-
codeflare terminal task
16+
codeflare designer
1717
```

Diff for: plugins/plugin-codeflare/src/controller/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export default function registerCodeflareCommands(registrar: Registrar) {
9999
registrar.listen("/codeflare/dashboard-gallery", (args) => import("./hello").then((_) => _.dashboardGallery(args)))
100100

101101
/** UI for running profile-related tasks */
102-
registrar.listen("/codeflare/terminal/task", (args) => import("./terminal").then((_) => _.task(args)), {
102+
registrar.listen("/codeflare/designer", (args) => import("./terminal").then((_) => _.designer(args)), {
103103
needsUI: true,
104104
})
105105

Diff for: plugins/plugin-codeflare/src/controller/terminal.tsx

+3-5
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ import Terminal, { Props as BaseProps } from "../components/RestartableTerminal"
3030
import "../../web/scss/components/Allotment/_index.scss"
3131
import "allotment/dist/style.css"
3232

33-
// codeflare -p ${SELECTED_PROFILE}
34-
3533
class AllotmentFillPane extends React.PureComponent<{ minSize?: number }> {
3634
public render() {
3735
return (
@@ -98,7 +96,7 @@ type State = Partial<Pick<BaseProps, "cmdline" | "env">> & {
9896
hideTerminal?: boolean
9997
}
10098

101-
export class TaskTerminal extends React.PureComponent<Props, State> {
99+
export class WorkloadDesigner extends React.PureComponent<Props, State> {
102100
/** Allotment initial split ... allotments */
103101
private readonly splits = {
104102
horizontal: [25, 75],
@@ -329,8 +327,8 @@ class Empty extends React.PureComponent<{ refresh(): void; gotit(): void }> {
329327

330328
/**
331329
* This is a command handler that opens up a terminal to run a selected profile-oriented task */
332-
export function task(args: Arguments) {
330+
export function designer(args: Arguments) {
333331
return {
334-
react: <TaskTerminal REPL={args.REPL} tab={args.tab} />,
332+
react: <WorkloadDesigner REPL={args.REPL} tab={args.tab} />,
335333
}
336334
}

Diff for: plugins/plugin-codeflare/src/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@
1616

1717
/* Your exported API */
1818

19-
export { TaskTerminal as WorkloadDesigner, Props as WorkloadDesignerProps } from "./controller/terminal"
19+
export { WorkloadDesigner, Props as WorkloadDesignerProps } from "./controller/terminal"

0 commit comments

Comments
 (0)