Skip to content

Commit 4adf94b

Browse files
committed
fix: refine some of the major groupings in ProfileExploer
Also: Specification -> Profile Also: remove icon beside that text
1 parent 91512d1 commit 4adf94b

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

Diff for: plugins/plugin-codeflare/src/components/ProfileExplorer.tsx

+16-15
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ import ProfileWatcher from "../tray/watchers/profile/list"
4040
// import UpdateFunction from "../tray/update"
4141
import { handleNew } from "../controller/profile/actions"
4242

43-
import Icon from "@patternfly/react-icons/dist/esm/icons/clipboard-list-icon"
44-
4543
import "../../web/scss/components/ProfileExplorer/_index.scss"
4644

4745
import LockIcon from "@patternfly/react-icons/dist/esm/icons/lock-icon"
@@ -360,7 +358,7 @@ class ProfileCard extends React.PureComponent<ProfileCardProps, ProfileCardState
360358
group: this.groups.Application,
361359
},
362360
"ml/codeflare/training/demos": {
363-
title: "Demo Code",
361+
title: "Code",
364362
group: this.groups.Application,
365363
},
366364
"ml/ray/start/resources": {
@@ -443,11 +441,6 @@ class ProfileCard extends React.PureComponent<ProfileCardProps, ProfileCardState
443441
)
444442
}
445443

446-
private readonly leafStyle = {}
447-
private leafFor(value: string) {
448-
return <span style={this.leafStyle}>{value}</span>
449-
}
450-
451444
private descriptionFor(desc: string) {
452445
return <span className="italic">{desc}</span>
453446
}
@@ -477,7 +470,7 @@ class ProfileCard extends React.PureComponent<ProfileCardProps, ProfileCardState
477470
return {
478471
id,
479472
title,
480-
name: this.leafFor(value),
473+
name: value,
481474
}
482475
}
483476
}
@@ -539,9 +532,19 @@ class ProfileCard extends React.PureComponent<ProfileCardProps, ProfileCardState
539532
children: [],
540533
}
541534
}
542-
const { children } = groups[meta.group.title]
543535

544-
children.push(this.editable(title, this.treeNode(title, meta, value)))
536+
const { children } = groups[meta.group.title]
537+
const already = children.find((_) => _.title === meta.title)
538+
539+
// meta.group.title: e.g. Application or Compute or Storage
540+
// meta.title: e.g. Scenario or Cluster/Namespace or Region
541+
// value: e.g. "Getting Started Demo" or yourNamespace or us-east
542+
if (already) {
543+
// there is
544+
already.name = already.name + ", " + value
545+
} else {
546+
children.push(this.editable(title, this.treeNode(title, meta, value)))
547+
}
545548
}
546549
}
547550

@@ -621,12 +624,10 @@ class ProfileCard extends React.PureComponent<ProfileCardProps, ProfileCardState
621624

622625
public render() {
623626
return (
624-
<Card isLarge isPlain>
627+
<Card isPlain>
625628
<CardHeader>
626629
<CardTitle>
627-
<div className="flex-layout">
628-
<Icon className="larger-text slightly-deemphasize small-right-pad" /> Specification
629-
</div>
630+
<div className="flex-layout">Profile</div>
630631
</CardTitle>
631632
<CardActions hasNoOffset>{this.actions()}</CardActions>
632633
</CardHeader>

0 commit comments

Comments
 (0)