Skip to content

Commit 5463725

Browse files
committed
fix: some UI refinements to the Profiles section of the Hello components
1) fixed tile text color in dark themes (not visible) 2) font size in tiles too small 3) maximized content 4) switch to using flex layout for profiles 5) inverse colors for gallery stripe
1 parent 442cf52 commit 5463725

File tree

4 files changed

+23
-19
lines changed

4 files changed

+23
-19
lines changed

plugins/plugin-client-default/notebooks/hello.md

+14-9
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,19 @@ layout:
66
position: default
77
2:
88
position: default
9+
maximized: true
10+
inverseColors: true
911
3:
1012
position: default
13+
maximized: true
1114
---
1215

1316
<img alt="CodeFlare Icon" src="@kui-shell/client/icons/svg/codeflare.svg" width="200" height="200" align="left" />
1417
CodeFlare is a framework to simplify the integration, scaling and acceleration of complex multi-step analytics and machine learning pipelines on the cloud.
1518

16-
From your terminal, try running `codeflare` to be guided through running jobs against the Cloud.
19+
> #### Next Steps
20+
>
21+
> From your terminal, try `codeflare` to be guided through running jobs against the Cloud.
1722
1823
---
1924

@@ -27,12 +32,12 @@ codeflare gallery
2732

2833
---
2934

30-
## Available Appliances
35+
=== "Your Profiles"
3136

32-
```shell
33-
---
34-
execute: now
35-
outputOnly: true
36-
---
37-
codeflare get profile
38-
```
37+
```shell
38+
---
39+
execute: now
40+
outputOnly: true
41+
---
42+
codeflare get profile
43+
```

plugins/plugin-codeflare/src/controller/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ export default function registerCodeflareCommands(registrar: Registrar) {
6262
registrar.listen("/codeflare/hello", (args) => import("./hello").then((_) => _.default(args)), {
6363
needsUI: true,
6464
outputOnly: true,
65-
width: 800,
66-
height: 600,
65+
width: 1000,
66+
height: 800,
6767
})
6868

6969
registrar.listen("/codeflare/gallery", () => import("./hello").then((_) => _.gallery()), {

plugins/plugin-codeflare/src/controller/profile/get.tsx

+5-5
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,21 @@
1616

1717
import React from "react"
1818
import { Profiles } from "madwizard"
19-
import { Grid, GridItem, Tile } from "@patternfly/react-core"
19+
import { Flex, FlexItem, Tile } from "@patternfly/react-core"
2020

2121
// eslint-disable-next-line @typescript-eslint/no-unused-vars
2222
export default async function getProfiles() {
2323
const profiles = await Profiles.list({})
2424

2525
return {
2626
react: (
27-
<Grid hasGutter className="codeflare--plain-grid" span={3}>
27+
<Flex className="flex-fill sans-serif top-pad left-pad right-pad bottom-pad">
2828
{profiles.map((_) => (
29-
<GridItem key={_.profile.name}>
29+
<FlexItem key={_.profile.name}>
3030
<Tile className="codeflare--tile" title={_.profile.name} />
31-
</GridItem>
31+
</FlexItem>
3232
))}
33-
</Grid>
33+
</Flex>
3434
),
3535
}
3636
}

plugins/plugin-codeflare/web/scss/components/Hello/_index.scss

+2-3
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
}
2828

2929
@include Split(3) {
30-
grid-template-rows: 1fr 1fr 1fr;
30+
grid-template-rows: 1.5fr 1fr 1fr;
3131
grid-template-columns: 1fr;
3232
grid-template-areas: "T1" "T2" "T3";
3333
}
@@ -84,7 +84,6 @@ $cell: 1.5em;
8484
}
8585

8686
@include Tile {
87-
--color-tile-title: var(--color-text-01);
8887
background-color: var(--color-base00);
8988

9089
&[data-status="SUCCEEDED"] {
@@ -115,5 +114,5 @@ $cell: 1.5em;
115114

116115
.pf-c-tile__title {
117116
color: var(--color-tile-title);
118-
font-size: 0.6875rem;
117+
font-size: 1rem;
119118
}

0 commit comments

Comments
 (0)