Skip to content

Commit 6a7e366

Browse files
committed
fix: updates to restore self-test capability vs private repos
1 parent ad11b37 commit 6a7e366

File tree

6 files changed

+39
-15
lines changed

6 files changed

+39
-15
lines changed

Diff for: deploy/self-test/Dockerfile

+6-4
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ FROM node:lts-bullseye-slim
33
LABEL org.opencontainers.image.source https://github.com/project-codeflare/codeflare-cli
44

55
ENV DEBIAN_FRONTEND=noninteractive
6+
7+
RUN apt update && apt -y install sudo curl python3 python3-pip git \
8+
&& pip3 install --no-cache-dir -U pip && pip3 install --no-cache-dir -U setuptools \
9+
&& apt -y clean && rm -rf /var/lib/apt/lists/*
10+
611
ENV KUI_HEADLESS=true
712
ENV KUI_HEADLESS_WEBPACK=true
813
ENV NO_KIND=true
@@ -13,10 +18,7 @@ ADD dist/headless /usr/local/CodeFlare
1318
ADD bin/codeflare /usr/local/bin/codeflare
1419
ADD node_modules/@guidebooks/store/dist/store /usr/local/CodeFlare/store
1520

16-
RUN apt update && apt -y install sudo curl python3 python3-pip git \
17-
&& pip3 install --no-cache-dir -U pip && pip3 install --no-cache-dir -U setuptools \
18-
&& apt -y clean && rm -rf /var/lib/apt/lists/* \
19-
&& codeflare -n util/jq \
21+
RUN codeflare -n util/jq \
2022
&& codeflare -n util/websocat \
2123
&& codeflare -n ml/ray/install/cli \
2224
&& codeflare -n openshift/oc \

Diff for: deploy/self-test/roberta/1gpu/once.yaml

+12
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,19 @@ spec:
4747
template:
4848
spec:
4949
serviceAccountName: codeflare-self-test-serviceaccount
50+
volumes:
51+
- name: ssh-key
52+
secret:
53+
secretName: github
54+
defaultMode: 0600
55+
optional: true
5056
containers:
5157
- name: self-test
5258
image: ghcr.io/project-codeflare/codeflare-self-test:0.11.3
59+
volumeMounts:
60+
- mountPath: "/tmp/github/"
61+
name: ssh-key
62+
readOnly: true
5363
env:
5464
# - name: GUIDEBOOK_RUN_ARGS
5565
# value: "-V"
@@ -76,11 +86,13 @@ spec:
7686
secretKeyRef:
7787
name: github
7888
key: GITHUB_USER
89+
optional: true
7990
- name: ML_CODEFLARE_ROBERTA_GITHUB_TOKEN
8091
valueFrom:
8192
secretKeyRef:
8293
name: github
8394
key: GITHUB_TOKEN
95+
optional: true
8496
- name: MODE
8597
value: development # otherwise building codeflare-cli takes a huge amount of memory
8698
- name: KUBE_CONTEXT_FOR_TEST

Diff for: deploy/self-test/roberta/1gpu/periodic.yaml

+10
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,19 @@ spec:
5151
template:
5252
spec:
5353
serviceAccountName: codeflare-self-test-serviceaccount
54+
volumes:
55+
- name: ssh-key
56+
secret:
57+
secretName: github
58+
defaultMode: 0600
59+
optional: true
5460
containers:
5561
- name: self-test
5662
image: ghcr.io/project-codeflare/codeflare-self-test:0.11.3
63+
volumeMounts:
64+
- mountPath: "/tmp/github/"
65+
name: ssh-key
66+
readOnly: true
5767
env:
5868
# - name: GUIDEBOOK_RUN_ARGS
5969
# value: "-V"

Diff for: deploy/self-test/self-test.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ function cleanup {
2525
ICON=":green_heart:"
2626
TEXT="$(date)\nSuccessful run\nVariants: $variants"
2727
else
28-
ICON=":red-siren:"
28+
ICON=":fail:"
2929
TEXT="$(date)\nFailed run\nVariants: $variants"
3030
# TODO, add tee'd logs of failing run
3131
fi

Diff for: package-lock.json

+9-9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: plugins/plugin-madwizard/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@
2424
},
2525
"dependencies": {
2626
"madwizard": "^0.21.5",
27-
"@guidebooks/store": "^0.8.3"
27+
"@guidebooks/store": "^0.9.0"
2828
}
2929
}

0 commit comments

Comments
 (0)