Skip to content

Commit 7c0f6a8

Browse files
committed
fix: further improvements to ray log streaming
- use websocat on the head node - use ray job logs, on the head node, to synchronize with job completion - avoid any use of stdin bindings on the client side - continue avoiding websocat installation on the client side
1 parent 66a726f commit 7c0f6a8

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

Diff for: package-lock.json

+9-9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: plugins/plugin-codeflare/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"@types/split2": "^3.2.1"
3131
},
3232
"dependencies": {
33-
"@guidebooks/store": "^7.6.1",
33+
"@guidebooks/store": "^7.6.3",
3434
"@logdna/tail-file": "^3.0.1",
3535
"@patternfly/react-charts": "^6.94.19",
3636
"@patternfly/react-core": "^4.276.8",

Diff for: tests/kind/run.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ function test {
243243

244244
# 4. validate the output of the job itself
245245
echo "[Test] Validating run output"
246-
if grep -q Succeeded $OUTPUT ; then
246+
if grep -iq Succeeded $OUTPUT ; then
247247
echo "[Test] ✅ Job submit output seems good!"
248248
else
249249
echo "[Test] ❌ Job submit output seems incomplete: $OUTPUT"

Diff for: tests/self-test/self-test.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ metadata:
99
name: codeflare-self-test-role
1010
rules:
1111
- apiGroups: [""]
12-
resources: ["pods", "pods/exec", "services", "events", "serviceaccounts", "configmaps"]
12+
resources: ["pods", "pods/exec", "pods/log", "services", "events", "serviceaccounts", "configmaps"]
1313
verbs: ["create", "delete", "get", "watch", "list"]
1414
- apiGroups: [""]
1515
resources: ["secrets"]

0 commit comments

Comments
 (0)