Skip to content

Commit 86ac7c6

Browse files
committed
fix: in ProfileExplorer place profile select in footer
1 parent 4d013d7 commit 86ac7c6

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Diff for: plugins/plugin-codeflare/src/components/ProfileExplorer.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import {
2424
CardBody,
2525
CardHeader,
2626
CardTitle,
27+
CardFooter,
2728
Chip,
2829
ChipGroup,
2930
Dropdown,
@@ -299,7 +300,6 @@ class ProfileCard extends React.PureComponent<ProfileCardProps, ProfileCardState
299300
private actions() {
300301
return (
301302
<React.Fragment>
302-
{this.title()}
303303
<Dropdown
304304
isOpen={this.state.isKebabOpen}
305305
isPlain
@@ -597,12 +597,13 @@ class ProfileCard extends React.PureComponent<ProfileCardProps, ProfileCardState
597597

598598
public render() {
599599
return (
600-
<Card isLarge>
600+
<Card isLarge isPlain isFullHeight>
601601
<CardHeader>
602602
<CardTitle>Draft Specification</CardTitle>
603603
<CardActions hasNoOffset>{this.actions()}</CardActions>
604604
</CardHeader>
605605
<CardBody>{this.body()}</CardBody>
606+
<CardFooter>{this.title()}</CardFooter>
606607
</Card>
607608
)
608609
}

Diff for: plugins/plugin-codeflare/src/components/ProfileSelect.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import React from "react"
1818
import prettyMillis from "pretty-ms"
1919
import { Profiles } from "madwizard"
20-
import { Select, SelectOption, SelectOptionObject, SelectVariant } from "@patternfly/react-core"
20+
import { Select, SelectOption, SelectOptionObject } from "@patternfly/react-core"
2121

2222
type Props = {
2323
selectedProfile?: string
@@ -81,7 +81,8 @@ export default class ProfileSelect extends React.PureComponent<Props, State> {
8181
public render() {
8282
return (
8383
<Select
84-
variant={SelectVariant.single}
84+
direction="up"
85+
variant="single"
8586
placeholderText="Select a profile"
8687
aria-label="Profiles selector with description"
8788
onToggle={this._selectOnToggle}

0 commit comments

Comments
 (0)