Skip to content

Commit d300e3d

Browse files
committed
fix: bumps to pick up improved cancel output and waiting for ray job to start
1 parent 2ca946e commit d300e3d

File tree

3 files changed

+25
-24
lines changed

3 files changed

+25
-24
lines changed

Diff for: package-lock.json

+16-16
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: plugins/plugin-codeflare/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@
3030
"@types/split2": "^3.2.1"
3131
},
3232
"dependencies": {
33-
"@guidebooks/store": "^2.3.2",
33+
"@guidebooks/store": "^2.3.4",
3434
"@logdna/tail-file": "^3.0.1",
3535
"@patternfly/react-charts": "^6.94.18",
3636
"@patternfly/react-core": "^4.276.6",
3737
"asciinema-player": "^3.0.1",
3838
"chokidar": "^3.5.3",
39-
"madwizard": "^5.2.7",
39+
"madwizard": "^5.2.8",
4040
"needle": "^3.2.0",
4141
"open": "^8.4.0",
4242
"pretty-bytes": "^6.0.0",

Diff for: plugins/plugin-codeflare/src/controller/attach.ts

+7-6
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17+
import chalk from "chalk"
1718
import Debug from "debug"
1819
import { MadWizardOptions } from "madwizard"
1920
import { Arguments, Capabilities, ParsedOptions } from "@kui-shell/core"
@@ -61,8 +62,8 @@ export async function attach(
6162
{
6263
appName,
6364
profile,
65+
quiet: true,
6466
interactive: false,
65-
verbose: true,
6667
},
6768
opts
6869
)
@@ -74,7 +75,7 @@ export async function attach(
7475
try {
7576
const deployOptions = Object.assign({}, options, { name: "log-aggregator-deploy" })
7677
debug("Deploying log aggregator", deployGuidebook, deployOptions)
77-
stderr("Deploying log aggregator...\n")
78+
stderr(chalk.yellow("Deploying log aggregator...\n"))
7879
await guide([appName, "guide", deployGuidebook], undefined, deployOptions)
7980
debug("deploying log aggregator: done")
8081
} catch (err) {
@@ -83,21 +84,21 @@ export async function attach(
8384
}
8485

8586
debug("attaching to", jobId)
86-
stderr("Attaching to job...\n")
87+
stderr(chalk.yellow("Attaching to job...\n"))
8788
const resp = await guide(
8889
[appName, "guide", startGuidebook],
8990
undefined,
9091
Object.assign({}, options, { name: "log-aggregator-start", clean: false })
9192
)
92-
stderr("Attaching to job done...\n")
93+
stderr(chalk.yellow("Attaching to job done...\n"))
9394

9495
// the logdir that we captured
9596
const logdir = resp && resp.env ? resp.env.LOGDIR_STAGE : undefined
9697
if (logdir) {
9798
debug("successfully attached to", jobId, logdir)
98-
stderr("Successfully attached to job")
99+
stderr(chalk.green("Successfully attached to job\n"))
99100
} else {
100-
stderr("Error in attach to job (logdir not found)")
101+
stderr(chalk.red("Error in attach to job (logdir not found)\n"))
101102
}
102103

103104
return {

0 commit comments

Comments
 (0)