Skip to content

Commit 12224be

Browse files
Add local-queue annotation to use created local queue by default in given namespace
1 parent b41e108 commit 12224be

File tree

3 files changed

+38
-3
lines changed

3 files changed

+38
-3
lines changed

support/environment.go

+6
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ const (
5454

5555
// Storage bucket credentials
5656
storageDefaultEndpoint = "AWS_DEFAULT_ENDPOINT"
57+
storageDefaultRegion = "AWS_DEFAULT_REGION"
5758
storageAccessKeyId = "AWS_ACCESS_KEY_ID"
5859
storageSecretKey = "AWS_SECRET_ACCESS_KEY"
5960
storageBucketName = "AWS_STORAGE_BUCKET"
@@ -133,6 +134,11 @@ func GetStorageBucketDefaultEndpoint() (string, bool) {
133134
return storage_endpoint, exists
134135
}
135136

137+
func GetStorageBucketDefaultRegion() (string, bool) {
138+
storage_default_region, exists := os.LookupEnv(storageDefaultRegion)
139+
return storage_default_region, exists
140+
}
141+
136142
func GetStorageBucketAccessKeyId() (string, bool) {
137143
storage_access_key_id, exists := os.LookupEnv(storageAccessKeyId)
138144
return storage_access_key_id, exists

support/kueue.go

+20-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ package support
1818

1919
import (
2020
"github.com/onsi/gomega"
21-
2221
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2322
kueuev1beta1 "sigs.k8s.io/kueue/apis/kueue/v1beta1"
2423
)
@@ -65,7 +64,20 @@ func CreateKueueClusterQueue(t Test, clusterQueueSpec kueuev1beta1.ClusterQueueS
6564
return clusterQueue
6665
}
6766

68-
func CreateKueueLocalQueue(t Test, namespace, clusterQueueName string) *kueuev1beta1.LocalQueue {
67+
var AsDefaultQueue = defaultLocalQueueOption{}
68+
69+
type defaultLocalQueueOption struct {
70+
}
71+
72+
func (d defaultLocalQueueOption) applyTo(to *kueuev1beta1.LocalQueue) error {
73+
if to.Annotations == nil {
74+
to.Annotations = make(map[string]string)
75+
}
76+
to.Annotations["kueue.x-k8s.io/default-queue"] = "true"
77+
return nil
78+
}
79+
80+
func CreateKueueLocalQueue(t Test, namespace string, clusterQueueName string, options ...Option[*kueuev1beta1.LocalQueue]) *kueuev1beta1.LocalQueue {
6981
t.T().Helper()
7082

7183
localQueue := &kueuev1beta1.LocalQueue{
@@ -82,7 +94,12 @@ func CreateKueueLocalQueue(t Test, namespace, clusterQueueName string) *kueuev1b
8294
},
8395
}
8496

85-
localQueue, err := t.Client().Kueue().KueueV1beta1().LocalQueues(namespace).Create(t.Ctx(), localQueue, metav1.CreateOptions{})
97+
//Apply options
98+
for _, opt := range options {
99+
t.Expect(opt.applyTo(localQueue)).To(gomega.Succeed())
100+
}
101+
102+
localQueue, err := t.Client().Kueue().KueueV1beta1().LocalQueues(localQueue.Namespace).Create(t.Ctx(), localQueue, metav1.CreateOptions{})
86103
t.Expect(err).NotTo(gomega.HaveOccurred())
87104
t.T().Logf("Created Kueue LocalQueue %s/%s successfully", localQueue.Namespace, localQueue.Name)
88105

support/kueue_test.go

+12
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,20 @@ func TestCreateKueueLocalQueue(t *testing.T) {
5656

5757
test.Expect(lq).To(gomega.Not(gomega.BeNil()))
5858
test.Expect(lq.GenerateName).To(gomega.Equal("lq-"))
59+
annotationKey := "kueue.x-k8s.io/default-queue"
60+
_, exists := lq.Annotations[annotationKey]
61+
test.Expect(exists).To(gomega.BeFalse(), "Annotation key %s should not exist", annotationKey)
5962
test.Expect(lq.Namespace).To(gomega.Equal("ns-1"))
6063
test.Expect(lq.Spec.ClusterQueue).To(gomega.Equal(kueuev1beta1.ClusterQueueReference("cq-1")))
64+
65+
default_lq := CreateKueueLocalQueue(test, "ns-2", "cq-2", AsDefaultQueue)
66+
67+
test.Expect(default_lq).To(gomega.Not(gomega.BeNil()))
68+
test.Expect(default_lq.GenerateName).To(gomega.Equal("lq-"))
69+
test.Expect(default_lq.Annotations["kueue.x-k8s.io/default-queue"]).To(gomega.Equal("true"))
70+
test.Expect(default_lq.Namespace).To(gomega.Equal("ns-2"))
71+
test.Expect(default_lq.Spec.ClusterQueue).To(gomega.Equal(kueuev1beta1.ClusterQueueReference("cq-2")))
72+
6173
}
6274

6375
func TestGetKueueWorkloads(t *testing.T) {

0 commit comments

Comments
 (0)