Skip to content

Commit 758dad4

Browse files
sutaakaropenshift-merge-bot[bot]
authored andcommitted
Cleanup of codeflare-common defaults and Makefile
Removing CodeFlare SDK version as CodeFlare SDK doesn't use Go lang tests any more. Adjusted Makefile to align with current content of defaults.go
1 parent 1fc12f8 commit 758dad4

File tree

4 files changed

+3
-28
lines changed

4 files changed

+3
-28
lines changed

Makefile

+1-5
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
1-
# CODEFLARE_SDK_VERSION defines the default version of the CodeFlare SDK
2-
CODEFLARE_SDK_VERSION ?= 0.9.0
3-
41
# RAY_VERSION defines the default version of Ray (used for testing)
52
RAY_VERSION ?= 2.35.0
63

74
# RAY_IMAGE defines the default container image for Ray (used for testing)
8-
RAY_IMAGE ?= rayproject/ray:$(RAY_VERSION)
5+
RAY_IMAGE ?= quay.io/modh/ray:2.35.0-py39-cu121
96

107
##@ Development
118

@@ -21,7 +18,6 @@ defaults:
2118
@echo "// ***********************" >> $(DEFAULTS_TEST_FILE)
2219
@echo "" >> $(DEFAULTS_TEST_FILE)
2320
@echo "const (" >> $(DEFAULTS_TEST_FILE)
24-
@echo " CodeFlareSDKVersion = \"$(CODEFLARE_SDK_VERSION)\"" >> $(DEFAULTS_TEST_FILE)
2521
@echo " RayVersion = \"$(RAY_VERSION)\"" >> $(DEFAULTS_TEST_FILE)
2622
@echo " RayImage = \"$(RAY_IMAGE)\"" >> $(DEFAULTS_TEST_FILE)
2723
@echo "" >> $(DEFAULTS_TEST_FILE)

support/defaults.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ package support
55
// ***********************
66

77
const (
8-
CodeFlareSDKVersion = "v0.20.2"
9-
RayVersion = "2.35.0"
10-
RayImage = "quay.io/modh/ray:2.35.0-py39-cu121"
8+
RayVersion = "2.35.0"
9+
RayImage = "quay.io/modh/ray:2.35.0-py39-cu121"
1110
)

support/environment.go

-5
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ const (
2525
// The environment variables hereafter can be used to change the components
2626
// used for testing.
2727

28-
CodeFlareTestSdkVersion = "CODEFLARE_TEST_SDK_VERSION"
2928
CodeFlareTestRayVersion = "CODEFLARE_TEST_RAY_VERSION"
3029
CodeFlareTestRayImage = "CODEFLARE_TEST_RAY_IMAGE"
3130
CodeFlareTestPyTorchImage = "CODEFLARE_TEST_PYTORCH_IMAGE"
@@ -71,10 +70,6 @@ const (
7170
UndefinedCluster ClusterType = "UNDEFINED"
7271
)
7372

74-
func GetCodeFlareSDKVersion() string {
75-
return lookupEnvOrDefault(CodeFlareTestSdkVersion, CodeFlareSDKVersion)
76-
}
77-
7873
func GetRayVersion() string {
7974
return lookupEnvOrDefault(CodeFlareTestRayVersion, RayVersion)
8075
}

support/environment_test.go

-15
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,6 @@ import (
88
"github.com/onsi/gomega"
99
)
1010

11-
func TestGetCodeFlareSDKVersion(t *testing.T) {
12-
13-
g := gomega.NewGomegaWithT(t)
14-
// Set the environment variable.
15-
os.Setenv(CodeFlareTestSdkVersion, "1.2.3")
16-
17-
// Get the version.
18-
version := GetCodeFlareSDKVersion()
19-
20-
// Assert that the version is correct.
21-
22-
g.Expect(version).To(gomega.Equal("1.2.3"), "Expected version 1.2.3, but got %s", version)
23-
24-
}
25-
2611
func TestGetRayVersion(t *testing.T) {
2712

2813
g := gomega.NewGomegaWithT(t)

0 commit comments

Comments
 (0)