Added parameters for S3 compatible storage bucket from which to download MNIST datasets

Author: abhijeet-dhumal

support/environment.go

@@ -29,6 +29,7 @@ const (
 	CodeFlareTestRayVersion   = "CODEFLARE_TEST_RAY_VERSION"
 	CodeFlareTestRayImage     = "CODEFLARE_TEST_RAY_IMAGE"
 	CodeFlareTestPyTorchImage = "CODEFLARE_TEST_PYTORCH_IMAGE"
+	NotebookImage             = "NOTEBOOK_IMAGE"
 
 	// The testing output directory, to write output files into.
 	CodeFlareTestOutputDir = "CODEFLARE_TEST_OUTPUT_DIR"
@@ -51,6 +52,13 @@ const (
 	// URL for PiPI index containing all the required test Python packages
 	pipIndexURL    = "PIP_INDEX_URL"
 	pipTrustedHost = "PIP_TRUSTED_HOST"
+
+	// Storage bucket credentials
+	storageDefaultEndpoint = "AWS_DEFAULT_ENDPOINT"
+	storageAccessKeyId     = "AWS_ACCESS_KEY_ID"
+	storageSecretKey       = "AWS_SECRET_ACCESS_KEY"
+	storageBucketName      = "AWS_STORAGE_BUCKET"
+	storageBucketMnistDir  = "AWS_STORAGE_BUCKET_MNIST_DIR"
 )
 
 type ClusterType string
@@ -79,6 +87,10 @@ func GetPyTorchImage() string {
 	return lookupEnvOrDefault(CodeFlareTestPyTorchImage, "pytorch/pytorch:1.11.0-cuda11.3-cudnn8-runtime")
 }
 
+func GetNotebookImage() string {
+	return lookupEnvOrDefault(NotebookImage, "quay.io/modh/odh-generic-data-science-notebook@sha256:bb33abc67af1328d3b32899f58bcdc0cf1681605e1b5da57f8fe8da81523a9bd")
+}
+
 func GetInstascaleOcmSecret() (string, string) {
 	res := strings.SplitN(lookupEnvOrDefault(InstaScaleOcmSecret, "default/instascale-ocm-secret"), "/", 2)
 	return res[0], res[1]
@@ -118,7 +130,30 @@ func GetClusterHostname(t Test) string {
 }
 
 func GetMnistDatasetURL() string {
-	return lookupEnvOrDefault(mnistDatasetURL, "http://yann.lecun.com/exdb/mnist/")
+	return lookupEnvOrDefault(mnistDatasetURL, "https://ossci-datasets.s3.amazonaws.com/mnist/")
+}
+
+func GetStorageBucketDefaultEndpoint() (string, bool) {
+	storage_endpoint, exists := os.LookupEnv(storageDefaultEndpoint)
+	return storage_endpoint, exists
+}
+
+func GetStorageBucketAccessKeyId() (string, bool) {
+	storage_access_key_id, exists := os.LookupEnv(storageAccessKeyId)
+	return storage_access_key_id, exists
+}
+
+func GetStorageBucketSecretKey() (string, bool) {
+	storage_secret_key, exists := os.LookupEnv(storageSecretKey)
+	return storage_secret_key, exists
+}
+
+func GetStorageBucketName() string {
+	return lookupEnvOrDefault(storageBucketName, "rhoai-dw")
+}
+
+func GetStorageBucketMnistDir() string {
+	return lookupEnvOrDefault(storageBucketMnistDir, "mnist-datasets")
 }
 
 func GetPipIndexURL() string {