Align SDK with validating webhook behaviour on enableIngress

ChristianZaccaria · ChristianZaccaria · commit 26731da91352 · 2024-04-26T13:14:09.000+01:00
diff --git a/src/codeflare_sdk/cluster/cluster.py b/src/codeflare_sdk/cluster/cluster.py
@@ -539,10 +539,10 @@ def _component_resources_up(
                         .get("headGroupSpec", {})
                         .get("enableIngress")
                     )
-                    if resource["kind"] == "RayCluster" and enable_ingress is not False:
+                    if resource["kind"] == "RayCluster" and enable_ingress is True:
                         name = resource["metadata"]["name"]
                         print(
-                            f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True' or is unset."
+                            f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True'."
                         )
                         return
                 _create_resources(yamls, namespace, api_instance)

Original file line number	Diff line number	Diff line change
`@@ -539,10 +539,10 @@ def _component_resources_up(`
`539`	`539`	`.get("headGroupSpec", {})`
`540`	`540`	`.get("enableIngress")`
`541`	`541`	`)`
`542`		`- if resource["kind"] == "RayCluster" and enable_ingress is not False:`
	`542`	`+ if resource["kind"] == "RayCluster" and enable_ingress is True:`
`543`	`543`	`name = resource["metadata"]["name"]`
`544`	`544`	`print(`
`545`		`- f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True' or is unset."`
	`545`	`+ f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True'."`
`546`	`546`	`)`
`547`	`547`	`return`
`548`	`548`	`_create_resources(yamls, namespace, api_instance)`