Skip to content

Commit 2f81c45

Browse files
Bobbins228Bobbins228
committed
test: update unit tests after resource creation refactor
1 parent f8238b2 commit 2f81c45

7 files changed

+62
-223
lines changed

‎tests/test-case-custom-image.yaml

+1-12
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ spec:
2929
block: 'true'
3030
dashboard-host: 0.0.0.0
3131
num-gpus: '0'
32-
resources: '"{}"'
3332
serviceType: ClusterIP
3433
template:
3534
spec:
@@ -71,8 +70,6 @@ spec:
7170
- mountPath: /etc/ssl/certs/odh-ca-bundle.crt
7271
name: odh-ca-cert
7372
subPath: odh-ca-bundle.crt
74-
imagePullSecrets:
75-
- name: unit-test-pull-secret
7673
volumes:
7774
- configMap:
7875
items:
@@ -92,21 +89,15 @@ spec:
9289
workerGroupSpecs:
9390
- groupName: small-group-unit-test-cluster-custom-image
9491
maxReplicas: 2
95-
minReplicas: 2
9692
rayStartParams:
9793
block: 'true'
9894
num-gpus: '7'
99-
resources: '"{}"'
10095
replicas: 2
10196
template:
102-
metadata:
103-
annotations:
104-
key: value
105-
labels:
106-
key: value
10797
spec:
10898
containers:
10999
- image: quay.io/project-codeflare/ray:2.20.0-py39-cu118
100+
imagePullPolicy: Always
110101
lifecycle:
111102
preStop:
112103
exec:
@@ -137,8 +128,6 @@ spec:
137128
- mountPath: /etc/ssl/certs/odh-ca-bundle.crt
138129
name: odh-ca-cert
139130
subPath: odh-ca-bundle.crt
140-
imagePullSecrets:
141-
- name: unit-test-pull-secret
142131
volumes:
143132
- configMap:
144133
items:

‎tests/test-case-no-kueue-no-aw.yaml

+1-12
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ spec:
2626
block: 'true'
2727
dashboard-host: 0.0.0.0
2828
num-gpus: '0'
29-
resources: '"{}"'
3029
serviceType: ClusterIP
3130
template:
3231
spec:
@@ -68,8 +67,6 @@ spec:
6867
- mountPath: /etc/ssl/certs/odh-ca-bundle.crt
6968
name: odh-ca-cert
7069
subPath: odh-ca-bundle.crt
71-
imagePullSecrets:
72-
- name: unit-test-pull-secret
7370
volumes:
7471
- configMap:
7572
items:
@@ -89,21 +86,15 @@ spec:
8986
workerGroupSpecs:
9087
- groupName: small-group-unit-test-no-kueue
9188
maxReplicas: 2
92-
minReplicas: 2
9389
rayStartParams:
9490
block: 'true'
9591
num-gpus: '7'
96-
resources: '"{}"'
9792
replicas: 2
9893
template:
99-
metadata:
100-
annotations:
101-
key: value
102-
labels:
103-
key: value
10494
spec:
10595
containers:
10696
- image: quay.io/rhoai/ray:2.23.0-py39-cu121
97+
imagePullPolicy: Always
10798
lifecycle:
10899
preStop:
109100
exec:
@@ -134,8 +125,6 @@ spec:
134125
- mountPath: /etc/ssl/certs/odh-ca-bundle.crt
135126
name: odh-ca-cert
136127
subPath: odh-ca-bundle.crt
137-
imagePullSecrets:
138-
- name: unit-test-pull-secret
139128
volumes:
140129
- configMap:
141130
items:

‎tests/test-case-no-mcad.yamls

+1-12
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ spec:
2929
block: 'true'
3030
dashboard-host: 0.0.0.0
3131
num-gpus: '0'
32-
resources: '"{}"'
3332
serviceType: ClusterIP
3433
template:
3534
spec:
@@ -71,8 +70,6 @@ spec:
7170
- mountPath: /etc/ssl/certs/odh-ca-bundle.crt
7271
name: odh-ca-cert
7372
subPath: odh-ca-bundle.crt
74-
imagePullSecrets:
75-
- name: unit-test-pull-secret
7673
volumes:
7774
- configMap:
7875
items:
@@ -92,21 +89,15 @@ spec:
9289
workerGroupSpecs:
9390
- groupName: small-group-unit-test-cluster-ray
9491
maxReplicas: 2
95-
minReplicas: 2
9692
rayStartParams:
9793
block: 'true'
9894
num-gpus: '7'
99-
resources: '"{}"'
10095
replicas: 2
10196
template:
102-
metadata:
103-
annotations:
104-
key: value
105-
labels:
106-
key: value
10797
spec:
10898
containers:
10999
- image: quay.io/rhoai/ray:2.23.0-py39-cu121
100+
imagePullPolicy: Always
110101
lifecycle:
111102
preStop:
112103
exec:
@@ -137,8 +128,6 @@ spec:
137128
- mountPath: /etc/ssl/certs/odh-ca-bundle.crt
138129
name: odh-ca-cert
139130
subPath: odh-ca-bundle.crt
140-
imagePullSecrets:
141-
- name: unit-test-pull-secret
142131
volumes:
143132
- configMap:
144133
items:

‎tests/test-case.yaml

+1-12
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ spec:
3434
block: 'true'
3535
dashboard-host: 0.0.0.0
3636
num-gpus: '0'
37-
resources: '"{}"'
3837
serviceType: ClusterIP
3938
template:
4039
spec:
@@ -76,8 +75,6 @@ spec:
7675
- mountPath: /etc/ssl/certs/odh-ca-bundle.crt
7776
name: odh-ca-cert
7877
subPath: odh-ca-bundle.crt
79-
imagePullSecrets:
80-
- name: unit-test-pull-secret
8178
volumes:
8279
- configMap:
8380
items:
@@ -97,21 +94,15 @@ spec:
9794
workerGroupSpecs:
9895
- groupName: small-group-unit-test-cluster
9996
maxReplicas: 2
100-
minReplicas: 2
10197
rayStartParams:
10298
block: 'true'
10399
num-gpus: '7'
104-
resources: '"{}"'
105100
replicas: 2
106101
template:
107-
metadata:
108-
annotations:
109-
key: value
110-
labels:
111-
key: value
112102
spec:
113103
containers:
114104
- image: quay.io/rhoai/ray:2.23.0-py39-cu121
105+
imagePullPolicy: Always
115106
lifecycle:
116107
preStop:
117108
exec:
@@ -142,8 +133,6 @@ spec:
142133
- mountPath: /etc/ssl/certs/odh-ca-bundle.crt
143134
name: odh-ca-cert
144135
subPath: odh-ca-bundle.crt
145-
imagePullSecrets:
146-
- name: unit-test-pull-secret
147136
volumes:
148137
- configMap:
149138
items:

‎tests/test-default-appwrapper.yaml

+1-10
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,9 @@ spec:
3434
block: 'true'
3535
dashboard-host: 0.0.0.0
3636
num-gpus: '0'
37-
resources: '"{}"'
3837
serviceType: ClusterIP
3938
template:
4039
spec:
41-
imagePullSecrets: []
4240
containers:
4341
- image: quay.io/rhoai/ray:2.23.0-py39-cu121
4442
imagePullPolicy: Always
@@ -96,22 +94,15 @@ spec:
9694
workerGroupSpecs:
9795
- groupName: small-group-unit-test-default-cluster
9896
maxReplicas: 1
99-
minReplicas: 1
10097
rayStartParams:
10198
block: 'true'
10299
num-gpus: '0'
103-
resources: '"{}"'
104100
replicas: 1
105101
template:
106-
metadata:
107-
annotations:
108-
key: value
109-
labels:
110-
key: value
111102
spec:
112-
imagePullSecrets: []
113103
containers:
114104
- image: quay.io/rhoai/ray:2.23.0-py39-cu121
105+
imagePullPolicy: Always
115106
lifecycle:
116107
preStop:
117108
exec:

0 commit comments

Comments
 (0)