test: update tests

Author: dimakis

Diff for: tests/unit_test.py

@@ -21,6 +21,8 @@
 import re
 import uuid
 
+from codeflare_sdk.cluster import cluster
+
 parent = Path(__file__).resolve().parents[1]
 sys.path.append(str(parent) + "/src")
 
@@ -250,6 +252,7 @@ def test_config_creation():
     assert config.dispatch_priority == None
     assert config.mcad == True
     assert config.local_interactive == False
+    
 
 
 def test_cluster_creation(mocker):
@@ -259,8 +262,7 @@ def test_cluster_creation(mocker):
     assert filecmp.cmp(
         "unit-test-cluster.yaml", f"{parent}/tests/test-case.yaml", shallow=True
     )
-
-
+    
 def test_cluster_creation_no_mcad(mocker):
     mocker.patch(
         "kubernetes.client.CustomObjectsApi.get_cluster_custom_object",
@@ -311,6 +313,7 @@ def test_default_cluster_creation(mocker):
     )
     default_config = ClusterConfiguration(
         name="unit-test-default-cluster",
+        image="quay.io/project-codeflare/ray:latest-py39-cu118",
     )
     cluster = Cluster(default_config)
 
@@ -614,6 +617,7 @@ def ingress_retrieval(port, annotations=None):
 
 def test_ray_job_wrapping(mocker):
     cluster = cluster = createClusterWithConfig(mocker)
+    cluster.config.image = "quay.io/project-codeflare/ray:latest-py39-cu118"
     mocker.patch(
         "ray.job_submission.JobSubmissionClient._check_connection_and_version_with_url",
         return_value="None",
@@ -732,7 +736,7 @@ def test_ray_details(mocker, capsys):
         "codeflare_sdk.cluster.cluster.Cluster.cluster_dashboard_uri",
         return_value="",
     )
-    cf = Cluster(ClusterConfiguration(name="raytest2", namespace="ns"))
+    cf = Cluster(ClusterConfiguration(name="raytest2", namespace="ns", image= "quay.io/project-codeflare/ray:latest-py39-cu118"))
     captured = capsys.readouterr()
     ray2 = _copy_to_ray(cf)
     details = cf.details()
@@ -1898,7 +1902,7 @@ def test_cluster_status(mocker):
         head_mem=8,
         head_gpu=0,
     )
-    cf = Cluster(ClusterConfiguration(name="test", namespace="ns"))
+    cf = Cluster(ClusterConfiguration(name="test", namespace="ns", image="quay.io/project-codeflare/ray:latest-py39-cu118"))
     mocker.patch("codeflare_sdk.cluster.cluster._app_wrapper_status", return_value=None)
     mocker.patch("codeflare_sdk.cluster.cluster._ray_cluster_status", return_value=None)
     status, ready = cf.status()
@@ -1988,7 +1992,7 @@ def test_wait_ready(mocker, capsys):
     mock_response = mocker.Mock()
     mock_response.status_code = 200
     mocker.patch("requests.get", return_value=mock_response)
-    cf = Cluster(ClusterConfiguration(name="test", namespace="ns"))
+    cf = Cluster(ClusterConfiguration(name="test", namespace="ns", image= "quay.io/project-codeflare/ray:latest-py39-cu118"))
     try:
         cf.wait_ready(timeout=5)
         assert 1 == 0
@@ -2653,7 +2657,7 @@ def test_gen_app_wrapper_with_oauth(mocker: MockerFixture):
     mocker.patch(
         "codeflare_sdk.utils.generate_yaml.write_user_appwrapper", write_user_appwrapper
     )
-    Cluster(ClusterConfiguration("test_cluster", openshift_oauth=True))
+    Cluster(ClusterConfiguration("test_cluster", openshift_oauth=True, image= "quay.io/project-codeflare/ray:latest-py39-cu118"))
     user_yaml = write_user_appwrapper.call_args.args[0]
     assert any(
         container["name"] == "oauth-proxy"

Diff for: tests/unit_test_support.py

@@ -59,6 +59,7 @@ def createClusterWithConfig(mocker):
         return_value={"spec": {"domain": "apps.cluster.awsroute.org"}},
     )
     cluster = Cluster(createClusterConfig())
+    cluster.config.image = "quay.io/project-codeflare/ray:latest-py39-cu118"
     return cluster