add: address comments

Author: VanillaSpoon

src/codeflare_sdk/cluster/cluster.py

@@ -19,12 +19,10 @@
 """
 
 from time import sleep
-from typing import List, Optional, Tuple, Dict
+from typing import List, Optional, Tuple
 
-import openshift as oc
 from kubernetes import config
 from ray.job_submission import JobSubmissionClient
-import urllib3
 
 from .auth import config_check, api_config_handler
 from ..utils import pretty_print
@@ -58,8 +56,6 @@ class Cluster:
     Note that currently, the underlying implementation is a Ray cluster.
     """
 
-    torchx_scheduler = "ray"
-
     def __init__(self, config: ClusterConfiguration):
         """
         Create the resource cluster object by passing in a ClusterConfiguration
@@ -472,20 +468,6 @@ def job_logs(self, job_id: str) -> str:
         """
         return self.job_client.get_job_logs(job_id)
 
-    def torchx_config(
-        self, working_dir: str = None, requirements: str = None
-    ) -> Dict[str, str]:
-        dashboard_address = urllib3.util.parse_url(self.cluster_dashboard_uri()).host
-        to_return = {
-            "cluster_name": self.config.name,
-            "dashboard_address": dashboard_address,
-        }
-        if working_dir:
-            to_return["working_dir"] = working_dir
-        if requirements:
-            to_return["requirements"] = requirements
-        return to_return
-
     def from_k8_cluster_object(
         rc,
         mcad=True,

tests/unit_test.py

@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# TODO: replace all instances of torchx_runner
 
 from pathlib import Path
 import sys
@@ -81,10 +80,6 @@
 import openshift
 from openshift.selector import Selector
 import ray
-from torchx.specs import AppDryRunInfo, AppDef
-from torchx.runner import get_runner, Runner
-from torchx.schedulers.ray_scheduler import RayJob
-from torchx.schedulers.kubernetes_mcad_scheduler import KubernetesMCADJob
 import pytest
 import yaml
 from unittest.mock import MagicMock