Align SDK with validating webhook behaviour on enableIngress

ChristianZaccaria · ChristianZaccaria · commit 56163ca86ad7 · 2024-05-07T10:01:38.000+01:00
diff --git a/src/codeflare_sdk/cluster/cluster.py b/src/codeflare_sdk/cluster/cluster.py
@@ -558,10 +558,10 @@ def _component_resources_up(
                         .get("headGroupSpec", {})
                         .get("enableIngress")
                     )
-                    if resource["kind"] == "RayCluster" and enable_ingress is not False:
+                    if resource["kind"] == "RayCluster" and enable_ingress is True:
                         name = resource["metadata"]["name"]
                         print(
-                            f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True' or is unset."
+                            f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True'."
                         )
                         return
                 _create_resources(yamls, namespace, api_instance)

Original file line number	Diff line number	Diff line change
`@@ -558,10 +558,10 @@ def _component_resources_up(`
`558`	`558`	`.get("headGroupSpec", {})`
`559`	`559`	`.get("enableIngress")`
`560`	`560`	`)`
`561`		`- if resource["kind"] == "RayCluster" and enable_ingress is not False:`
	`561`	`+ if resource["kind"] == "RayCluster" and enable_ingress is True:`
`562`	`562`	`name = resource["metadata"]["name"]`
`563`	`563`	`print(`
`564`		`- f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True' or is unset."`
	`564`	`+ f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True'."`
`565`	`565`	`)`
`566`	`566`	`return`
`567`	`567`	`_create_resources(yamls, namespace, api_instance)`