Align SDK with validating webhook behaviour on enableIngress

ChristianZaccaria · openshift-merge-bot[bot] · commit a9bcce0a6493 · 2024-05-13T14:32:06.000Z
diff --git a/src/codeflare_sdk/cluster/cluster.py b/src/codeflare_sdk/cluster/cluster.py
@@ -560,10 +560,10 @@ def _component_resources_up(
                         .get("headGroupSpec", {})
                         .get("enableIngress")
                     )
-                    if resource["kind"] == "RayCluster" and enable_ingress is not False:
+                    if resource["kind"] == "RayCluster" and enable_ingress is True:
                         name = resource["metadata"]["name"]
                         print(
-                            f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True' or is unset."
+                            f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True'."
                         )
                         return
                 _create_resources(yamls, namespace, api_instance)

Original file line number	Diff line number	Diff line change
`@@ -560,10 +560,10 @@ def _component_resources_up(`
`560`	`560`	`.get("headGroupSpec", {})`
`561`	`561`	`.get("enableIngress")`
`562`	`562`	`)`
`563`		`- if resource["kind"] == "RayCluster" and enable_ingress is not False:`
	`563`	`+ if resource["kind"] == "RayCluster" and enable_ingress is True:`
`564`	`564`	`name = resource["metadata"]["name"]`
`565`	`565`	`print(`
`566`		`- f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True' or is unset."`
	`566`	`+ f"Forbidden: RayCluster '{name}' has 'enableIngress' set to 'True'."`
`567`	`567`	`)`
`568`	`568`	`return`
`569`	`569`	`_create_resources(yamls, namespace, api_instance)`