refactor: update deployment and default flag for /metrics on port 8083

Author: dimakis

Diff for: cmd/kar-controllers/app/options/options.go

@@ -56,6 +56,7 @@ type ServerOption struct {
 	QuotaRestURL          string
 	HealthProbeListenAddr string
 	DispatchResourceReservationTimeout int64
+	MetricsListenAddr    string
 }
 
 // NewServerOption creates a new CMServer with a default config.
@@ -82,6 +83,7 @@ func (s *ServerOption) AddFlags(fs *flag.FlagSet) {
 	fs.StringVar(&s.QuotaRestURL, "quotaURL", s.QuotaRestURL, "URL for ReST quota management.  Default is none.")
 	fs.IntVar(&s.SecurePort, "secure-port", 6443, "The port on which to serve secured, authenticated access for metrics.")
 	fs.StringVar(&s.HealthProbeListenAddr, "healthProbeListenAddr", ":8081", "Listen address for health probes. Defaults to ':8081'")
+	fs.StringVar(&s.MetricsListenAddr, "metricsListenAddr", ":8083", "Listen address for metrics. Defaults to ':8083'")
 	fs.Int64Var(&s.DispatchResourceReservationTimeout, "dispatchResourceReservationTimeout", s.DispatchResourceReservationTimeout, "Resource reservation timeout for pods to be created once AppWrapper is dispatched, in millisecond.  Defaults to '300000', 5 minutes")
 	flag.Parse()
 	klog.V(4).Infof("[AddFlags] Controller configuration: %#v", s)

Diff for: deployment/mcad-controller/templates/deployment.yaml

@@ -352,6 +352,8 @@ spec:
           name: https
         - containerPort: 8080
           name: http
+        - containerPort: 8083
+          name: metrics
         volumeMounts:
         - mountPath: /tmp
           name: temp-vol
@@ -371,6 +373,10 @@ spec:
             port: 8081
           periodSeconds: 5
           timeoutSeconds: 5
+        metrics:
+          httpGet:
+           path: /metrics
+           port: 8083
 #{{ if .Values.configMap.name }}
         envFrom:
         - configMapRef: