address review 1

asm582 · asm582 · commit 7a8e3dc4a2ad · 2023-10-09T16:20:44.000-04:00
diff --git a/pkg/controller/queuejob/queuejob_controller_ex.go b/pkg/controller/queuejob/queuejob_controller_ex.go
@@ -371,9 +371,9 @@ func (qjm *XController) PreemptQueueJobs(inspectAw *arbv1.AppWrapper) {
 				}
 				// cannot use cleanup AW, since it puts AW back in running state
 				qjm.qjqueue.AddUnschedulableIfNotPresent(updateNewJob)
+				generatedCondition = true
 
 			}
-			generatedCondition = true
 		}
 
 		if ((newjob.Status.Running + newjob.Status.Succeeded) < int32(newjob.Spec.SchedSpec.MinAvailable)) && newjob.Status.State == arbv1.AppWrapperStateActive {

Original file line number	Diff line number	Diff line change
`@@ -371,9 +371,9 @@ func (qjm XController) PreemptQueueJobs(inspectAw arbv1.AppWrapper) {`
`371`	`371`	`}`
`372`	`372`	`// cannot use cleanup AW, since it puts AW back in running state`
`373`	`373`	`qjm.qjqueue.AddUnschedulableIfNotPresent(updateNewJob)`
	`374`	`+ generatedCondition = true`
`374`	`375`
`375`	`376`	`}`
`376`		`- generatedCondition = true`
`377`	`377`	`}`
`378`	`378`
`379`	`379`	`if ((newjob.Status.Running + newjob.Status.Succeeded) < int32(newjob.Spec.SchedSpec.MinAvailable)) && newjob.Status.State == arbv1.AppWrapperStateActive {`