Skip to content

Commit f34e1f5

Browse files
asm582openshift-merge-robot
authored andcommitted
add git issues and remove commented code
1 parent ac8a463 commit f34e1f5

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

Diff for: pkg/controller/queuejob/queuejob_controller_ex.go

+2-10
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ func NewJobController(config *rest.Config, serverOption *options.ServerOption) *
172172
//TODO: work on enabling metrics adapter for correct MCAD mode
173173
//metrics adapter is implemented through dynamic client which looks at all the
174174
//resources installed in the cluster to construct cache. May be this is need in
175-
//multi-cluster mode, so for now it is turned-off
175+
//multi-cluster mode, so for now it is turned-off: https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/585
176176
//cc.metricsAdapter = adapter.New(serverOption, config, cc.cache)
177177

178178
cc.genericresources = genericresource.NewAppWrapperGenericResource(config)
@@ -1246,7 +1246,7 @@ func (qjm *XController) ScheduleNext(qj *arbv1.AppWrapper) {
12461246
go qjm.backoff(ctx, qj, dispatchFailedReason, dispatchFailedMessage)
12471247
}
12481248
// if the HeadOfLineHoldingTime option is not set it will break the loop
1249-
//TODO: Remove schedulingTimeExpired flag
1249+
//TODO: Remove schedulingTimeExpired flag: https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/586
12501250
schedulingTimeExpired := false
12511251
if forwarded {
12521252
break
@@ -2046,14 +2046,6 @@ func (cc *XController) manageQueueJob(ctx context.Context, qj *arbv1.AppWrapper,
20462046
klog.Errorf("[manageQueueJob] Error updating status 'setQueueing' for AppWrapper: '%s/%s',Status=%+v, err=%+v.", qj.Namespace, qj.Name, qj.Status, err)
20472047
return err
20482048
}
2049-
// if err00 = cc.qjqueue.AddIfNotPresent(qj); err00 != nil {
2050-
// klog.Errorf("[manageQueueJob] [Dispatcher] Fail to add '%s/%s' to activeQueue. Back to eventQueue activeQ=%t Unsched=%t &qj=%p Version=%s Status=%+v err=%#v",
2051-
// qj.Namespace, qj.Name, cc.qjqueue.IfExistActiveQ(qj), cc.qjqueue.IfExistUnschedulableQ(qj), qj, qj.ResourceVersion, qj.Status, err00)
2052-
// cc.enqueue(qj)
2053-
// } else {
2054-
// klog.V(4).Infof("[manageQueueJob] [Dispatcher] '%s/%s' 1Delay=%.6f seconds activeQ.Add_success activeQ=%t Unsched=%t &qj=%p Version=%s Status=%+v",
2055-
// qj.Namespace, qj.Name, time.Now().Sub(qj.Status.ControllerFirstTimestamp.Time).Seconds(), cc.qjqueue.IfExistActiveQ(qj), cc.qjqueue.IfExistUnschedulableQ(qj), qj, qj.ResourceVersion, qj.Status)
2056-
// }
20572049
}
20582050
return nil
20592051
}

0 commit comments

Comments
 (0)