Skip to content

[core] Suboptimal implementation of backoff -- re-queueing behaviours #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
z103cb opened this issue Jul 26, 2023 · 0 comments
Closed
Labels
enhancement New feature or request

Comments

@z103cb
Copy link
Contributor

z103cb commented Jul 26, 2023

Description

The current implementation of the backoff function needs to be improved to allow for better memory / cpu consumption by MCAD.

In its current implementation of the func (qjm *XController) backoff(q *arbv1.AppWrapper, reason string, message string) { uses a call time.Sleep(time.Duration(qjm.serverOption.BackoffTime) * time.Second) to "backoff" the scheduling of the new appwrappers or app wrappers that have been created.

The backoff function is called at this points in the code:

What would you want to see

MCAD should use timer implementation that would cope with a large number of app wrappers that would need to be backed off (no resource available or preemption)

@z103cb z103cb added the enhancement New feature or request label Jul 26, 2023
@asm582 asm582 changed the title Suboptimal implementation of backoff -- re-queueing behaviours [core] Suboptimal implementation of backoff -- re-queueing behaviours Aug 24, 2023
@asm582 asm582 mentioned this issue Sep 6, 2023
4 tasks
@asm582 asm582 closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants