From 6b95bd4216dbdf4cc5ce828bdbd55a7bb20e5e5c Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Wed, 20 May 2020 17:44:57 +0800 Subject: [PATCH 1/2] Use COPY instead of ADD for files and folders in Dockerfile Reference: - https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 2c7c62e..00d87f5 100644 --- a/Dockerfile +++ b/Dockerfile @@ -8,7 +8,7 @@ RUN yum install -y --setopt=tsflags=nodocs npm && \ yum clean all WORKDIR /opt/dockerfile_lint -ADD . . +COPY . . RUN npm install && \ ln -s /opt/dockerfile_lint/bin/dockerfile_lint /usr/bin/dockerfile_lint From 78761cf45ebb6c8030e3d9970c08396c723ab657 Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Wed, 20 May 2020 17:46:39 +0800 Subject: [PATCH 2/2] Use arguments JSON notation for CMD arguments Reference: - https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#cmd --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 00d87f5..f15b71e 100644 --- a/Dockerfile +++ b/Dockerfile @@ -21,4 +21,4 @@ RUN mkdir /sample_rules && \ WORKDIR /root/ LABEL RUN docker run -it --rm --privileged -v `pwd`:/root/ -v /var/run/docker.sock:/var/run/docker.sock --name NAME -e NAME=NAME -e IMAGE=IMAGE IMAGE dockerfile_lint -CMD /bin/bash +CMD ["/bin/bash"]