fix: longRunningTransactionsAgeInSeconds

roock · roock · commit 5e3acfc34bfb · 2023-11-30T15:58:50.000+01:00
- clock_timestamp will just return the current timestamp
- what we actually want to know is the lowest timestamp of the xact_start column
diff --git a/collector/pg_long_running_transactions.go b/collector/pg_long_running_transactions.go
@@ -52,7 +52,7 @@ var (
 	longRunningTransactionsQuery = `
 	SELECT
 		COUNT(*) as transactions,
-   		MAX(EXTRACT(EPOCH FROM clock_timestamp())) AS oldest_timestamp_seconds
+		MIN(EXTRACT(EPOCH FROM xact_start)) AS oldest_timestamp_seconds
     FROM pg_catalog.pg_stat_activity
     WHERE state is distinct from 'idle' AND query not like 'autovacuum:%'
 	`

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ var (`
`52`	`52`	longRunningTransactionsQuery = `
`53`	`53`	`SELECT`
`54`	`54`	`COUNT(*) as transactions,`
`55`		`- MAX(EXTRACT(EPOCH FROM clock_timestamp())) AS oldest_timestamp_seconds`
	`55`	`+ MIN(EXTRACT(EPOCH FROM xact_start)) AS oldest_timestamp_seconds`
`56`	`56`	`FROM pg_catalog.pg_stat_activity`
`57`	`57`	`WHERE state is distinct from 'idle' AND query not like 'autovacuum:%'`
`58`	`58`	`