Skip to content

Commit c1195f9

Browse files
chore: dont rely on slice labels (#184)
Signed-off-by: Michael Hoffmann <[email protected]>
1 parent a2c1355 commit c1195f9

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

injectproxy/rules.go

+4-10
Original file line numberDiff line numberDiff line change
@@ -207,11 +207,8 @@ func (r *routes) filterRules(lvalues []string, resp *apiResponse) (interface{},
207207
for _, rg := range rgs.RuleGroups {
208208
var rules []rule
209209
for _, rule := range rg.Rules {
210-
for _, lbl := range rule.Labels() {
211-
if lbl.Name == r.label && slices.Contains(lvalues, lbl.Value) {
212-
rules = append(rules, rule)
213-
break
214-
}
210+
if lval := rule.Labels().Get(r.label); lval != "" && slices.Contains(lvalues, lval) {
211+
rules = append(rules, rule)
215212
}
216213
}
217214
if len(rules) > 0 {
@@ -231,11 +228,8 @@ func (r *routes) filterAlerts(lvalues []string, resp *apiResponse) (interface{},
231228

232229
filtered := []*alert{}
233230
for _, alert := range data.Alerts {
234-
for _, lbl := range alert.Labels {
235-
if lbl.Name == r.label && slices.Contains(lvalues, lbl.Value) {
236-
filtered = append(filtered, alert)
237-
break
238-
}
231+
if lval := alert.Labels.Get(r.label); lval != "" && slices.Contains(lvalues, lval) {
232+
filtered = append(filtered, alert)
239233
}
240234
}
241235

0 commit comments

Comments
 (0)