Address comments

Signed-off-by: Ying WANG <[email protected]>

Author: ying-jeanne

CHANGELOG.md

@@ -1,7 +1,5 @@
 ## Unreleased
 
-* [ENHANCEMENT] process_collector: Add Platform-Specific Describe for processCollector. #1625
-
 ## 1.20.2 / 2024-08-23
 
 * [BUGFIX] promhttp: Unset Content-Encoding header when data is uncompressed. #1596

prometheus/process_collector.go

@@ -125,18 +125,18 @@ func NewProcessCollector(opts ProcessCollectorOpts) Collector {
 		c.collectFn = c.processCollect
 		c.describeFn = c.describe
 	} else {
-		c.collectFn = c.defaultCollectFn
-		c.describeFn = c.defaultDescribeFn
+		c.collectFn = c.errorCollectFn
+		c.describeFn = c.errorDescribeFn
 	}
 
 	return c
 }
 
-func (c *processCollector) defaultCollectFn(ch chan<- Metric) {
+func (c *processCollector) errorCollectFn(ch chan<- Metric) {
 	c.reportError(ch, nil, errors.New("process metrics not supported on this platform"))
 }
 
-func (c *processCollector) defaultDescribeFn(ch chan<- *Desc) {
+func (c *processCollector) errorDescribeFn(ch chan<- *Desc) {
 	if c.reportErrors {
 		ch <- NewInvalidDesc(errors.New("process metrics not supported on this platform"))
 	}

prometheus/process_collector_js.go

@@ -25,9 +25,9 @@ func canCollectProcess() bool {
 // in the processCollect method. Any changes to the metrics in processCollect
 // (such as adding or removing metrics) should be reflected in this list of descriptors.
 func (c *processCollector) processCollect(ch chan<- Metric) {
-	c.defaultCollect(ch)
+	c.errorCollectFn(ch)
 }
 
 func (c *processCollector) describe(ch chan<- *Desc) {
-	c.defaultDescribe(ch)
+	c.errorDescribeFn(ch)
 }

prometheus/process_collector_wasip1.go

@@ -21,13 +21,13 @@ func canCollectProcess() bool {
 }
 
 func (c *processCollector) processCollect(ch chan<- Metric) {
-	c.defaultCollect(ch)
+	c.errorCollectFn(ch)
 }
 
 // describe returns all descriptions of the collector for wasip1.
 // Ensure that this list of descriptors is kept in sync with the metrics collected
 // in the processCollect method. Any changes to the metrics in processCollect
 // (such as adding or removing metrics) should be reflected in this list of descriptors.
 func (c *processCollector) describe(ch chan<- *Desc) {
-	c.defaultDescribe(ch)
+	c.errorDescribeFn(ch)
 }