Increase offset for relative fill()s

Author: dcodeIO

README.md

@@ -3,7 +3,7 @@
 A fast and complete ByteBuffer implementation using either ArrayBuffers in the browser or node Buffers under node.js,
 generated from a single source tree through [MetaScript](https://github.com/dcodeIO/MetaScript).
 
-If you are looking for ByteBuffer.js 2, [that's the branch](https://github.com/dcodeIO/ByteBuffer.js/tree/ByteBuffer2).
+If you are looking for ByteBuffer.js 2 (ArrayBuffers only), [that's the branch](https://github.com/dcodeIO/ByteBuffer.js/tree/ByteBuffer2).
 
 What can it do?
 ---------------

dist/ByteBufferAB.js

@@ -1827,8 +1827,8 @@
          *  read if omitted.
          * @returns {!ByteBuffer} this
          * @expose
-         * @example `A relative `<01 02>03.append(<04 05>)` will result in `<01 02 04 05>, 04 05|`
-         * @example `An absolute `<01 02>03.append(04 05>, 1)` will result in `<01 04>05, 04 05|`
+         * @example A relative `<01 02>03.append(<04 05>)` will result in `<01 02 04 05>, 04 05|`
+         * @example An absolute `<01 02>03.append(04 05>, 1)` will result in `<01 04>05, 04 05|`
          */
         ByteBuffer.prototype.append = function(source, encoding, offset) {
             if (typeof encoding === 'number' || typeof encoding !== 'string') {
@@ -2075,6 +2075,8 @@
          * @example `someByteBuffer.clear().fill(0)` fills the entire backing buffer with zeroes
          */
         ByteBuffer.prototype.fill = function(value, begin, end) {
+            var relative = typeof begin === 'undefined';
+            if (relative) begin = this.offset;
             if (typeof value === 'string' && value.length > 0)
                 value = value.charCodeAt(0);
             if (typeof begin === 'undefined') begin = this.offset;
@@ -2094,6 +2096,9 @@
             }
             if (begin >= end) return this; // Nothing to fill
             while (begin < end) this.view.setUint8(begin++, value);
+            if (relative) {
+                this.offset = begin;
+            }
             return this;
         };
 

dist/ByteBufferAB.min.js

@@ -1978,8 +1978,8 @@ module.exports = (function() {
      *  read if omitted.
      * @returns {!ByteBuffer} this
      * @expose
-     * @example `A relative `<01 02>03.append(<04 05>)` will result in `<01 02 04 05>, 04 05|`
-     * @example `An absolute `<01 02>03.append(04 05>, 1)` will result in `<01 04>05, 04 05|`
+     * @example A relative `<01 02>03.append(<04 05>)` will result in `<01 02 04 05>, 04 05|`
+     * @example An absolute `<01 02>03.append(04 05>, 1)` will result in `<01 04>05, 04 05|`
      */
     ByteBuffer.prototype.append = function(source, encoding, offset) {
         if (typeof encoding === 'number' || typeof encoding !== 'string') {
@@ -2222,6 +2222,8 @@ module.exports = (function() {
      * @example `someByteBuffer.clear().fill(0)` fills the entire backing buffer with zeroes
      */
     ByteBuffer.prototype.fill = function(value, begin, end) {
+        var relative = typeof begin === 'undefined';
+        if (relative) begin = this.offset;
         if (typeof value === 'string' && value.length > 0)
             value = value.charCodeAt(0);
         if (typeof begin === 'undefined') begin = this.offset;
@@ -2241,6 +2243,10 @@ module.exports = (function() {
         }
         if (begin >= end) return this; // Nothing to fill
         this.buffer.fill(value, begin, end);
+        begin = end;
+        if (relative) {
+            this.offset = begin;
+        }
         return this;
     };
 

dist/ByteBufferAB.min.js.gz

@@ -4538,9 +4538,9 @@ <h5>Returns:</h5>
 
         <h5>Examples</h5>
 
-    <pre class="prettyprint"><code> `A relative `<01 02>03.append(<04 05>)` will result in `<01 02 04 05>, 04 05|`</code></pre>
+    <pre class="prettyprint"><code> A relative `<01 02>03.append(<04 05>)` will result in `<01 02 04 05>, 04 05|`</code></pre>
 
-    <pre class="prettyprint"><code> `An absolute `<01 02>03.append(04 05>, 1)` will result in `<01 04>05, 04 05|`</code></pre>
+    <pre class="prettyprint"><code> An absolute `<01 02>03.append(04 05>, 1)` will result in `<01 04>05, 04 05|`</code></pre>
 
 
 </dd>

dist/ByteBufferAB.min.map

@@ -2,7 +2,7 @@
     "name": "bytebuffer",
     "version": "3.0.0-pre",
     "author": "Daniel Wirtz <[email protected]>",
-    "description": "A full-featured, zero-copy aware ByteBuffer implementation for both typed arrays and node buffers.",
+    "description": "The swiss army knife for binary data in JavaScript.",
     "main": "ByteBuffer.js",
     "repository": {
         "type": "git",

dist/ByteBufferNB.js

@@ -13,8 +13,8 @@
  *  read if omitted.
  * @returns {!ByteBuffer} this
  * @expose
- * @example `A relative `<01 02>03.append(<04 05>)` will result in `<01 02 04 05>, 04 05|`
- * @example `An absolute `<01 02>03.append(04 05>, 1)` will result in `<01 04>05, 04 05|`
+ * @example A relative `<01 02>03.append(<04 05>)` will result in `<01 02 04 05>, 04 05|`
+ * @example An absolute `<01 02>03.append(04 05>, 1)` will result in `<01 04>05, 04 05|`
  */
 ByteBuffer.prototype.append = function(source, encoding, offset) {
     if (typeof encoding === 'number' || typeof encoding !== 'string') {

docs/module-ByteBuffer.html

@@ -2,13 +2,15 @@
  * Overwrites this ByteBuffer's contents with the specified value. Contents are the bytes between
  *  {@link ByteBuffer#offset} and {@link ByteBuffer#limit}.
  * @param {number|string} value Byte value to fill with. If given as a string, the first character is used.
- * @param {number=} begin Begin offset, defaults to {@link ByteBuffer#offset}.
+ * @param {number=} begin Begin offset. Will use and increase {@link ByteBuffer#offset} by the number of bytes
+ *  written if omitted. defaults to {@link ByteBuffer#offset}.
  * @param {number=} end End offset, defaults to {@link ByteBuffer#limit}.
  * @returns {!ByteBuffer} this
  * @expose
  * @example `someByteBuffer.clear().fill(0)` fills the entire backing buffer with zeroes
  */
 ByteBuffer.prototype.fill = function(value, begin, end) {
+    //? RELATIVE(undefined, 'begin');
     if (typeof value === 'string' && value.length > 0)
         value = value.charCodeAt(0);
     if (typeof begin === 'undefined') begin = this.offset;
@@ -18,11 +20,15 @@ ByteBuffer.prototype.fill = function(value, begin, end) {
         //? ASSERT_RANGE();
     }
     if (begin >= end) return this; // Nothing to fill
-    //? if (NODE)
+    //? if (NODE) {
     this.buffer.fill(value, begin, end);
-    //? else {
+    begin = end;
+    //? } else {
     while (begin < end) this.view.setUint8(begin++, value);
     //? }
+    if (relative) {
+        this.offset = begin;
+    }
     return this;
 };
 

package.json

@@ -19,6 +19,7 @@
  * @author Daniel Wirtz <[email protected]>
  */ //
 var ByteBuffer = require("../index.js");
+ByteBuffer.ByteBufferAB = require("../dist/ByteBufferAB.min.js"); // Test minified version
 
 /**
  * Constructs a new Sandbox for module loaders and shim testing.
@@ -339,7 +340,7 @@ function makeSuite(ByteBuffer) {
 
     suite.methods.copyTo = function(test) {
         var bb = ByteBuffer.wrap("\x01"),
-            bb2 = new ByteBuffer(2).fill(0);
+            bb2 = new ByteBuffer(2).fill(0).flip();
         test.equal(bb.toDebug(), "<01>");
         // Modifies source and target offsets
         bb.copyTo(bb2 /* all offsets omitted */);
@@ -352,14 +353,14 @@ function makeSuite(ByteBuffer) {
         test.equal(bb.toDebug(), "01|"); // Read 1 byte
         test.equal(bb2.toDebug(), "01 01|"); // Written 1 byte at 2
         bb.reset();
-        bb2.reset().fill(0);
+        bb2.clear().fill(0).flip();
         // Modifies source offsets only
         bb.copyTo(bb2, 0 /* source offsets omitted */);
         test.equal(bb.toDebug(), "01|"); // Read 1 byte
         test.equal(bb2.toDebug(), "<01 00>"); // Written 1 byte (no change)
         // Modifies no offsets at all
         bb.reset();
-        bb2.fill(0);
+        bb2.fill(0).flip();
         bb.copyTo(bb2, 1, 0, bb.capacity() /* no offsets omitted */);
         test.equal(bb.toDebug(), "<01>"); // Read 1 byte (no change)
         test.equal(bb2.toDebug(), "<00 01>"); // Written 1 byte (no change)