Skip to content

[PULP-398] Porting guide to bindings for 3.70 and how to build pre 3.70 versions #6263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bmbouter opened this issue Feb 5, 2025 · 2 comments · May be fixed by pulp/pulp-openapi-generator#111
Open

[PULP-398] Porting guide to bindings for 3.70 and how to build pre 3.70 versions #6263

bmbouter opened this issue Feb 5, 2025 · 2 comments · May be fixed by pulp/pulp-openapi-generator#111
Labels
Documentation Task

Comments

@bmbouter
Copy link
Member

bmbouter commented Feb 5, 2025

With 3.70, my understanding is there are breaking changes in the bindings. There are good reasons for them (not recapped here), but my understanding is these changes are best for our community in the long term. There is a roundup of the breaking changes here.

That being said, I think bindings users need clear documentation on two things. This ticket is tracking the creation of those docs.

  • How to port bindings usage with a clear example for each breaking change they need to handle.
  • How to build the old bindings yourself if you don't want to port right now.
@pedro-psb
Copy link
Member

I think this documentation should be added to the pulp-openapi-generator repository.

In pulpcore, we should update this page to point to the oa-gen docs.

@pedro-psb pedro-psb changed the title Porting guide to bindings for 3.70 and how to build pre 3.70 versions [PULP-398] Porting guide to bindings for 3.70 and how to build pre 3.70 versions Mar 19, 2025
@pedro-psb
Copy link
Member

pedro-psb commented May 14, 2025 •
edited
Loading

How to build the old bindings yourself if you don't want to port right now.

This is not currently supported (e.g, generating old bindings for pulpcore>=3.70). That would be a new "feature" of the pulp-openapi-generator to allow that.

It's actually really simple to add (and I can add it if there is still the feeling it's needed), but I just think it would be unhelpful to add that knob without tests (and without explicit downstream/upstream requests). IMHO it's just unlikely to work, since there couplings between the generator and pulpcore for some version ranges.

@pedro-psb pedro-psb linked a pull request May 14, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PULP-398] Update docs on bindings generation pedro-psb/pulp-openapi-generator
3 participants
@bmbouter @dkliban @pedro-psb