Add dependency on puppetlabs_yum and use it

This removes the logic in the repos manifest and instead uses a module which
already implements the same logic. It adds the dependency in the modulefile,
.fixtures.yml. It also adds a new param to the main class which can be used to
decide whether or not to include the pl repos.
This also moves the include on epel into init.pp and updates the previous
package dependency from rpmbuilder::repos to epel.

Author: haus

.fixtures.yml

@@ -1,5 +1,6 @@
 fixtures:
   repositories:
     epel: https://github.com/stahnma/puppet-module-epel.git
+    puppetlabs_yum: https://github.com/stahnma/puppet-module-puppetlabs_yum.git
   symlinks:
     rpmbuilder: "#{source_dir}"

Modulefile

@@ -1,5 +1,5 @@
 name    'puppetlabs-rpmbuilder'
-version '0.0.2'
+version '0.0.3'
 source  'https://github.com/Whopper92/puppetlabs-rpmbuilder'
 author  'Puppet Labs'
 license 'Apache License 2.0'
@@ -9,3 +9,4 @@ project_page 'https://github.com/Whopper92/puppetlabs-rpmbuilder'
 
 ## Add dependencies, if any:
 dependency 'stahnma/puppet-module-epel', '>= 0.0.1'
+dependency 'stahnma/puppet-module-puppetlabs_yum', '>= 0.1.0'

manifests/init.pp

@@ -6,8 +6,12 @@
   $proxy            = undef,
   $pe               = false,
   $pe_vers          = undef,
+  $add_pl_repos     = true,
 ) {
-  include rpmbuilder::repos
+  if $add_pl_repos {
+    include puppetlabs_yum
+  }
+  include epel
   include rpmbuilder::packages::essential
 
   class { rpmbuilder::mock::puppetlabs_mocks:

manifests/packages/essential.pp

@@ -1,6 +1,6 @@
 class rpmbuilder::packages::essential {
   Package {
-    require  => Class['rpmbuilder::repos']
+    require  => Class['epel']
   }
 
   $builder_pkgs = [

manifests/packages/extra.pp

@@ -8,6 +8,6 @@
   ]
   package { $builder_pkgs:
     ensure => installed,
-    require => Class['rpmbuilder::repos'],
+    require => Class['epel'],
    }
 }

manifests/repos.pp

@@ -10,6 +10,7 @@
       :proxy            => nil,
       :pe               => false,
       :pe_vers          => nil,
+      :add_pl_repos     => true,
     }
   end
 
@@ -22,6 +23,7 @@
       :proxy            => "http://proxy.puppetlabs.com:1234",
       :pe               => true,
       :pe_vers          => ["1.2","lance"],
+      :add_pl_repos     => false,
    }].each do |param_set|
     let(:param_hash) do
       default_params.merge(param_set)
@@ -32,7 +34,14 @@
     end
 
     describe "Using #{param_set == {} ? "default params" : "specifying params"}" do
-      it { should contain_Rpmbuilder__Repos }
+      it do
+        if param_hash[:add_pl_repos]
+          should contain_Puppetlabs_yum
+        else
+          should_not contain_Puppetlabs_yum
+        end
+      end
+
       it { should contain_Rpmbuilder__Packages__Essential }
 
       it { should contain_Rpmbuilder__Mock__Puppetlabs_Mocks.with({