(maint) Restore rubocop line length

Author: pcarlisle

.rubocop.yml

@@ -59,6 +59,3 @@ Metrics/ParameterLists:
 
 Metrics/PerceivedComplexity:
   Enabled: false
-
-Metrics/LineLength:
-    Max: 130

lib/bolt/cli.rb

@@ -119,7 +119,8 @@ def create_option_parser(results)
         end
         results[:concurrency] = 100
         opts.on('-c', '--concurrency CONCURRENCY', Integer,
-                "Maximum number of simultaneous connections (Optional, defaults to 100)") do |concurrency|
+                "Maximum number of simultaneous connections " \
+                "(Optional, defaults to 100)") do |concurrency|
           results[:concurrency] = concurrency
         end
         opts.on('--modules MODULES', "Path to modules directory") do |modules|

lib/bolt/node/orch.rb

@@ -84,7 +84,11 @@ def unwrap_bolt_result(result)
     end
 
     def _run_command(command, options = {})
-      result = _run_task(BOLT_MOCK_FILE, 'stdin', action: 'command', command: command, options: options)
+      result = _run_task(BOLT_MOCK_FILE,
+                         'stdin',
+                         action: 'command',
+                         command: command,
+                         options: options)
       unwrap_bolt_result(result)
     end
 

lib/bolt/node/winrm.rb

@@ -117,7 +117,8 @@ def execute(command, _ = {})
     # 10 minutes in milliseconds
     DEFAULT_EXECUTION_TIMEOUT = 10 * 60 * 1000
 
-    def execute_process(path = '', arguments = '', stdin = nil, timeout_ms = DEFAULT_EXECUTION_TIMEOUT)
+    def execute_process(path = '', arguments = '', stdin = nil,
+                        timeout_ms = DEFAULT_EXECUTION_TIMEOUT)
       execute(<<-PS)
 $invokeArgs = @{
   Path = "#{path}"
@@ -133,6 +134,9 @@ def execute_process(path = '', arguments = '', stdin = nil, timeout_ms = DEFAULT
 
     VALID_EXTENSIONS = ['.ps1', '.rb'].freeze
 
+    PS_ARGS =
+      '-NoProfile -NonInteractive -NoLogo -ExecutionPolicy Bypass'.freeze
+
     def process_from_extension(path)
       case Pathname(path).extname.downcase
       when '.rb'
@@ -143,7 +147,7 @@ def process_from_extension(path)
       when '.ps1'
         [
           'powershell.exe',
-          "-NoProfile -NonInteractive -NoLogo -ExecutionPolicy Bypass -File \"#{path}\""
+          "#{PS_ARGS} -File \"#{path}\""
         ]
       end
     end
@@ -201,7 +205,7 @@ def _run_command(command)
     def _run_script(script)
       @logger.info { "Running script '#{script}'" }
       with_remote_file(script) do |remote_path|
-        args = "-NoProfile -NonInteractive -NoLogo -ExecutionPolicy Bypass -File \"#{remote_path}\""
+        args = "#{PS_ARGS} -File \"#{remote_path}\""
         execute_process('powershell.exe', args)
       end
     end

spec/bolt/cli_spec.rb

@@ -117,7 +117,8 @@
       cli = Bolt::CLI.new(%w[command run --nodes foo --concurrency])
       expect {
         cli.parse
-      }.to raise_error(Bolt::CLIError, /option '--concurrency' needs a parameter/)
+      }.to raise_error(Bolt::CLIError,
+                       /option '--concurrency' needs a parameter/)
     end
   end
 

spec/bolt/node/orch_spec.rb

@@ -100,32 +100,35 @@ def set_script_params(path, _options = {})
     end
 
     it 'errors when not in a module' do
-      expect { orch.task_name_from_path('foo/nottasks/init.sh') }.to raise_error(ArgumentError)
+      expect { orch.task_name_from_path('foo/nottasks/init.sh') }
+        .to raise_error(ArgumentError)
     end
   end
 
   describe :_run_task do
     it "executes a task on a host" do
       mock_client
-      expect(orch._run_task(@taskpath, 'stdin', @params).value).to eq(@result.to_json)
+      expect(orch._run_task(@taskpath, 'stdin', @params).value)
+        .to eq(@result.to_json)
     end
 
     it "returns a success" do
       mock_client
-      expect(orch._run_task(@taskpath, 'stdin', @params).class).to eq(Bolt::Node::Success)
+      expect(orch._run_task(@taskpath, 'stdin', @params)).to be_success
     end
 
     context "the task failed" do
       before(:each) { @result_state = 'failed' }
 
       it "returns a failure for failed" do
         mock_client
-        expect(orch._run_task(@taskpath, 'stdin', @params).class).to eq(Bolt::Node::Failure)
+        expect(orch._run_task(@taskpath, 'stdin', @params)).not_to be_success
       end
 
       it "adds an unkown exitcode when absent" do
         mock_client
-        expect(orch._run_task(@taskpath, 'stdin', @params).exit_code).to eq('unknown')
+        expect(orch._run_task(@taskpath, 'stdin', @params).exit_code)
+          .to eq('unknown')
       end
 
       it "uses the exitcode when present" do
@@ -149,7 +152,7 @@ def set_script_params(path, _options = {})
       end
 
       it 'it is a success' do
-        expect(orch._run_command(@command).class).to eq(Bolt::Node::Success)
+        expect(orch._run_command(@command)).to be_success
       end
 
       it 'captures stderr' do
@@ -166,7 +169,7 @@ def set_script_params(path, _options = {})
         bolt_task_client
       end
       it 'is a failure' do
-        expect(orch._run_command(@command).class).to eq(Bolt::Node::Failure)
+        expect(orch._run_command(@command)).not_to be_success
       end
 
       it 'captures the exit_code' do
@@ -190,14 +193,15 @@ def set_script_params(path, _options = {})
   describe :_upload do
     it 'should write the file' do
       Dir.mktmpdir(nil, '/tmp') do |dir|
-        source_path = File.join(base_path, 'spec', 'fixtures', 'scripts', 'success.sh')
+        source_path = File.join(base_path, 'spec', 'fixtures',
+                                'scripts', 'success.sh')
         dest_path = File.join(dir, "success.sh")
 
         set_upload_params(source_path, dest_path)
         bolt_task_client
         result = orch._upload(source_path, dest_path)
 
-        expect(result.class).to eq(Bolt::Node::Success)
+        expect(result).to be_success
 
         source_mode = File.stat(source_path).mode
         dest_mode = File.stat(dest_path).mode
@@ -213,7 +217,7 @@ def set_script_params(path, _options = {})
   describe :_run_script do
     context "the script succeeds" do
       let(:script_path) do
-        File.expand_path(File.join(base_path, 'spec', 'fixtures', 'scripts', 'success.sh'))
+        File.join(base_path, 'spec', 'fixtures', 'scripts', 'success.sh')
       end
 
       before(:each) do
@@ -222,7 +226,7 @@ def set_script_params(path, _options = {})
       end
 
       it 'is a success' do
-        expect(orch._run_script(script_path).class).to eq(Bolt::Node::Success)
+        expect(orch._run_script(script_path)).to be_success
       end
 
       it 'captures stdout' do
@@ -238,7 +242,7 @@ def set_script_params(path, _options = {})
 
     context "when the script fails" do
       let(:script_path) do
-        File.expand_path(File.join(base_path, 'spec', 'fixtures', 'scripts', 'failure.sh'))
+        File.join(base_path, 'spec', 'fixtures', 'scripts', 'failure.sh')
       end
 
       before(:each) do
@@ -247,7 +251,7 @@ def set_script_params(path, _options = {})
       end
 
       it 'returns a failure' do
-        expect(orch._run_script(script_path).class).to eq(Bolt::Node::Failure)
+        expect(orch._run_script(script_path)).not_to be_success
       end
 
       it 'captures exit_code' do

spec/bolt/node/winrm_spec.rb

@@ -73,7 +73,10 @@
     with_tempfile_containing('tasks-test-both-winrm', contents) do |file|
       expect(
         winrm._run_task(file.path, 'both', arguments).value
-      ).to eq("Hello from task\r\nGoodbye\r\n{\"message_one\":\"Hello from task\",\"message_two\":\"Goodbye\"}\r\n\r\n")
+      ).to eq(['Hello from task',
+               'Goodbye',
+               '{"message_one":"Hello from task","message_two":"Goodbye"}',
+               "\r\n"].join("\r\n"))
     end
   end
 end