Skip to content

Commit c115e94

Browse files
authored
Fix tooltip error on hover when disabled (#504)
* Fix error on hover * Update change log and package.json * Fix lint error
1 parent 73f898d commit c115e94

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## react-components 5.32.1 (2022-01-31)
2+
3+
-- [TooltipHoverArea] Prevent udpate method from being called when undefined. (by [@krable55](https://github.com/krable55) in [#504](https://github.com/puppetlabs/design-system/pull/504))
4+
15
## react-components 5.32.0 (2022-01-11)
26

37
- [Form] Pass other props to Form component to form element (by [@vine77](https://github.com/vine77) in [#487](https://github.com/puppetlabs/design-system/pull/487))
@@ -7,6 +11,7 @@
711

812
- [TableActions] Add table action dropdown to the table header component (by [@Lukeaber](https://github.com/Lukeaber) in [#483](https://github.com/puppetlabs/design-system/pull/483)
913
- [SelectWithPagination] Add's the new conditional rendering, props and implementation pattern for Selection with pagination (by [@Lukeaber](https://github.com/Lukeaber) in [#483](https://github.com/puppetlabs/design-system/pull/483)
14+
1015
# react-components 5.31.0 (2021-12-20)
1116

1217
- [Icon] Add ban, pause and caret-right icon (by [@Lukeaber](https://github.com/Lukeaber) in [#483](https://github.com/puppetlabs/design-system/pull/483)

packages/react-components/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-components/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@puppet/react-components",
3-
"version": "5.32.0",
3+
"version": "5.32.1",
44
"author": "Puppet, Inc.",
55
"license": "Apache-2.0",
66
"main": "build/library.js",

packages/react-components/source/react/library/tooltips/TooltipHoverArea.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,10 @@ const TooltipHoverArea = ({
113113
// Manage tooltip visibility
114114
const mouseIn = () => {
115115
// popper.js doesn't take into account layout changes, so we need to update it manually
116-
update();
116+
if (update) {
117+
// eslint-disable-next-line no-unused-expressions
118+
update();
119+
}
117120
if (!disabled) showTooltip();
118121
};
119122
const mouseOut = () => hideTooltip();

0 commit comments

Comments
 (0)