Skip to content

Commit d579236

Browse files
committed
Update icon contribution instructions
1 parent bc96409 commit d579236

File tree

1 file changed

+1
-1
lines changed
  • packages/react-components/source/react/library/icon

1 file changed

+1
-1
lines changed

packages/react-components/source/react/library/icon/Icon.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ const Renderer = () => {
127127
1. _Design_: Create a new icon following the checklist and naming conventions on the [Iconography](#/Foundations/Iconography) Foundations page.
128128
2. _Engineering_: Run the SVG through [svgo](https://github.com/svg/svgo) to minify and remove redundant data.
129129
3. _Engineering_: Strip out the wrapping `svg` element, usually (but not always) leaving just a `path`.
130-
4. _Engineering_: Remove all instances of the `fill` attribute so that icons can be styled with CSS.
130+
4. _Engineering_: Remove all instances of the `fill` attribute so that icons can be styled with CSS. You may also remove `clip-rule` attributes.
131131
5. _Engineering_: Add the icon to [icons.js](https://github.com/puppetlabs/design-system/blob/master/packages/react-components/source/react/library/icon/icons.js), specifying the icon name and native SVG sizes (usually "medium" for 16px but optionally also "tiny" for 8px, "small" for 12px, or "large" for 24px).
132132

133133
## Related

0 commit comments

Comments
 (0)