From a8ef75c6b9814492d2863908ac5e5fec777e1ae9 Mon Sep 17 00:00:00 2001 From: Nathan Ward Date: Mon, 16 Mar 2020 10:13:30 -0700 Subject: [PATCH 1/6] Order components by name --- packages/react-components/source/index.js | 72 +++++++++++------------ 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/packages/react-components/source/index.js b/packages/react-components/source/index.js index 56b3f4033..18197a7d7 100644 --- a/packages/react-components/source/index.js +++ b/packages/react-components/source/index.js @@ -2,63 +2,63 @@ import 'core-js'; // TODO: Potentially remove polyfills from package, after tria import 'regenerator-runtime/runtime'; import ActionSelect from './react/library/action-select'; +import Alert from './react/library/alert'; +import Badge from './react/library/badge'; +import Breadcrumb from './react/library/breadcrumb'; import Button from './react/library/button'; import ButtonSelect from './react/library/button-select'; import Card from './react/library/card'; -import Sidebar from './react/library/sidebar'; -import Icon from './react/library/icon'; -import Table from './react/library/table'; -import Input from './react/library/input'; -import Switch from './react/library/switch'; -import Loading from './react/library/loading'; -import Modal from './react/library/modal'; -import TooltipHoverArea from './react/library/tooltips/TooltipHoverArea'; -import Select from './react/library/select'; -import Form from './react/library/form'; -import Filters from './react/library/filters'; import Checkbox from './react/library/checkbox'; +import Code from './react/library/code'; +import ConfirmationModal from './react/library/confirmation-modal'; import Content from './react/library/content'; +import Filters from './react/library/filters'; +import Form from './react/library/form'; import Heading from './react/library/heading'; -import Text from './react/library/text'; -import Alert from './react/library/alert'; -import Badge from './react/library/badge'; +import Icon from './react/library/icon'; +import Input from './react/library/input'; import Link from './react/library/link'; +import Loading from './react/library/loading'; import Logo from './react/library/logo'; -import Tabs from './react/library/tabs'; -import Breadcrumb from './react/library/breadcrumb'; -import ConfirmationModal from './react/library/confirmation-modal'; -import Code from './react/library/code'; +import Modal from './react/library/modal'; import RadioButton from './react/library/radiobutton'; +import Select from './react/library/select'; +import Sidebar from './react/library/sidebar'; +import Switch from './react/library/switch'; +import Table from './react/library/table'; +import Tabs from './react/library/tabs'; import Tag from './react/library/tag'; +import Text from './react/library/text'; +import TooltipHoverArea from './react/library/tooltips/TooltipHoverArea'; export { ActionSelect, + Alert, + Badge, + Breadcrumb, Button, ButtonSelect, - Card, + Card, + Checkbox, + Code, + ConfirmationModal, + Content, + Filters, + Form, + Heading, Icon, - Table, Input, - Switch, + Link, Loading, + Logo, Modal, - TooltipHoverArea, + RadioButton, Select, - Form, - Filters, - Checkbox, - Content, Sidebar, - Heading, - Text, - Alert, - Badge, - Link, - Logo, + Switch, + Table, Tabs, - Breadcrumb, - ConfirmationModal, - Code, - RadioButton, Tag, + Text, + TooltipHoverArea, }; From 4e1f4d989911c70be60d2671051568facb32d33f Mon Sep 17 00:00:00 2001 From: Nathan Ward Date: Mon, 16 Mar 2020 10:19:22 -0700 Subject: [PATCH 2/6] Add SidePanel and Toolbar to index --- packages/react-components/source/index.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/react-components/source/index.js b/packages/react-components/source/index.js index 18197a7d7..0108254db 100644 --- a/packages/react-components/source/index.js +++ b/packages/react-components/source/index.js @@ -24,11 +24,13 @@ import Modal from './react/library/modal'; import RadioButton from './react/library/radiobutton'; import Select from './react/library/select'; import Sidebar from './react/library/sidebar'; +import SidePanel from './react/library/sidepanel'; import Switch from './react/library/switch'; import Table from './react/library/table'; import Tabs from './react/library/tabs'; import Tag from './react/library/tag'; import Text from './react/library/text'; +import Toolbar from './react/library/toolbar'; import TooltipHoverArea from './react/library/tooltips/TooltipHoverArea'; export { @@ -55,10 +57,12 @@ export { RadioButton, Select, Sidebar, + SidePanel, Switch, Table, Tabs, Tag, Text, + Toolbar, TooltipHoverArea, }; From f60493bf9edc419c1737b2837e3919df953a98d7 Mon Sep 17 00:00:00 2001 From: Nathan Ward Date: Tue, 17 Mar 2020 23:36:41 -0700 Subject: [PATCH 3/6] Fix lint error in SidePanel.js --- .../react-components/source/react/library/sidepanel/SidePanel.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-components/source/react/library/sidepanel/SidePanel.js b/packages/react-components/source/react/library/sidepanel/SidePanel.js index b6b60a7ac..79323dc8a 100644 --- a/packages/react-components/source/react/library/sidepanel/SidePanel.js +++ b/packages/react-components/source/react/library/sidepanel/SidePanel.js @@ -16,6 +16,7 @@ const propTypes = { const defaultProps = { children: null, + closeButtonProps: {}, open: true, title: '', onClose() {}, From 1e3e9991bc2ee09a18cc49e95f50021f7965d353 Mon Sep 17 00:00:00 2001 From: Nathan Ward Date: Wed, 18 Mar 2020 00:08:27 -0700 Subject: [PATCH 4/6] Rename script to `npm run release` --- package.json | 2 +- packages/data-grid/package.json | 3 +-- packages/react-components/package.json | 3 +-- packages/react-layouts/package.json | 3 +-- packages/sass-variables/package.json | 1 - packages/uikit/package.json | 3 +-- 6 files changed, 5 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index ea79bdacd..a0335db7c 100644 --- a/package.json +++ b/package.json @@ -9,7 +9,7 @@ "test": "lerna run lint && lerna run test", "start": "cd packages/design-system-website && npm start", "styleguide:build": "cd packages/design-system-website && npm run styleguide:build", - "publish": "lerna publish" + "release": "lerna publish" }, "devDependencies": { "@babel/preset-stage-2": "^7.0.0", diff --git a/packages/data-grid/package.json b/packages/data-grid/package.json index 14f98c2de..e8c61cb2b 100644 --- a/packages/data-grid/package.json +++ b/packages/data-grid/package.json @@ -104,6 +104,5 @@ "\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "/src/__mocks__/fileMock.js", "\\.(css|less|scss)$": "/src/__mocks__/styleMock.js" } - }, - "gitHead": "4a6c41ff75aabb2ec705588e6ab757fc69ac9f97" + } } diff --git a/packages/react-components/package.json b/packages/react-components/package.json index 5a599c4c3..0b9d4a0ee 100644 --- a/packages/react-components/package.json +++ b/packages/react-components/package.json @@ -88,6 +88,5 @@ "react-transition-group": "^4.3.0", "regenerator-runtime": "^0.13.5", "scroll-into-view-if-needed": "^2.2.24" - }, - "gitHead": "4a6c41ff75aabb2ec705588e6ab757fc69ac9f97" + } } diff --git a/packages/react-layouts/package.json b/packages/react-layouts/package.json index 027f39552..b0e7a5127 100644 --- a/packages/react-layouts/package.json +++ b/packages/react-layouts/package.json @@ -89,6 +89,5 @@ "webpack-hot-middleware": "^2.25.0", "webpack-merge": "^4.2.2", "webpack-node-externals": "^1.7.2" - }, - "gitHead": "4a6c41ff75aabb2ec705588e6ab757fc69ac9f97" + } } diff --git a/packages/sass-variables/package.json b/packages/sass-variables/package.json index a72c44e0e..c6ef729fb 100644 --- a/packages/sass-variables/package.json +++ b/packages/sass-variables/package.json @@ -13,7 +13,6 @@ "devDependencies": { "stylelint-config-prettier": "^6.0.0" }, - "gitHead": "4a6c41ff75aabb2ec705588e6ab757fc69ac9f97", "dependencies": { "prettier": "^1.19.1", "stylelint": "^11.1.1", diff --git a/packages/uikit/package.json b/packages/uikit/package.json index ecee93b27..dc4a2d6d3 100644 --- a/packages/uikit/package.json +++ b/packages/uikit/package.json @@ -44,6 +44,5 @@ "prettier": "^1.19.1", "sinon": "^7.5.0", "sinon-chai": "^3.5.0" - }, - "gitHead": "4a6c41ff75aabb2ec705588e6ab757fc69ac9f97" + } } From b00b655b4207f8decc457f254fdb1e5b42408f81 Mon Sep 17 00:00:00 2001 From: Nathan Ward Date: Wed, 18 Mar 2020 00:24:42 -0700 Subject: [PATCH 5/6] Update Columns class names --- packages/react-layouts/src/Columns/Columns.jsx | 8 +++++--- packages/react-layouts/src/Columns/Columns.scss | 8 ++++++-- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/packages/react-layouts/src/Columns/Columns.jsx b/packages/react-layouts/src/Columns/Columns.jsx index 77b58ea66..975c21a42 100644 --- a/packages/react-layouts/src/Columns/Columns.jsx +++ b/packages/react-layouts/src/Columns/Columns.jsx @@ -1,7 +1,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import classNames from 'classnames'; -// import './Columns.scss'; +import './Columns.scss'; const columnsPropTypes = { children: PropTypes.node, @@ -13,7 +13,7 @@ const columnsDefaultProps = { }; const Columns = ({ children, className }) => ( -
{children}
+
{children}
); Columns.propTypes = columnsPropTypes; @@ -31,7 +31,9 @@ const columnDefaultProps = { }; const Column = ({ children, className, fixed }) => ( -
{children}
+
+ {children} +
); Column.propTypes = columnPropTypes; diff --git a/packages/react-layouts/src/Columns/Columns.scss b/packages/react-layouts/src/Columns/Columns.scss index fd31c8f6e..b455599d0 100644 --- a/packages/react-layouts/src/Columns/Columns.scss +++ b/packages/react-layouts/src/Columns/Columns.scss @@ -1,14 +1,18 @@ -.columns { +.rc-columns { display: flex; flex-direction: row; } -.column { +.rc-column { flex-grow: 1; flex-shrink: 1; flex-basis: auto; min-width: 0; + &:empty { + display: none; + } + &.fixed { flex-grow: 0; flex-shrink: 0; From b50b81232d9ebc7961e9234e6714bc57c3407f51 Mon Sep 17 00:00:00 2001 From: Nathan Ward Date: Wed, 18 Mar 2020 00:24:58 -0700 Subject: [PATCH 6/6] Add border prop to Toolbar and Sidebar --- packages/react-components/CHANGELOG.md | 6 +++++- .../react/library/sidepanel/SidePanel.js | 10 +++++++++- .../source/react/library/toolbar/Toolbar.js | 13 +++++++++++-- .../source/react/library/toolbar/Toolbar.md | 6 +++--- .../scss/library/components/_sidepanel.scss | 6 +++++- .../scss/library/components/_toolbar.scss | 18 +++++++++++++++--- .../react-layouts/src/Columns/Columns.scss | 1 + 7 files changed, 49 insertions(+), 11 deletions(-) diff --git a/packages/react-components/CHANGELOG.md b/packages/react-components/CHANGELOG.md index 0096c24c7..6b21353e5 100644 --- a/packages/react-components/CHANGELOG.md +++ b/packages/react-components/CHANGELOG.md @@ -1,6 +1,10 @@ -# [Unreleased](https://github.com/puppetlabs/design-system/compare/@puppet/react-components@5.18.0...HEAD) +# [Unreleased](https://github.com/puppetlabs/design-system/compare/@puppet/react-components@5.19.1...HEAD) + +# [5.19.1](https://github.com/puppetlabs/design-system/compare/@puppet/react-components@5.19.0...@puppet/react-components@5.19.1) (2020-03-18) - [Docs] Add instructions for setting up fonts in different environments (by [sprokusk](https://github.com/sprokusk) in [#233](https://github.com/puppetlabs/design-system/pull/233)) +- [SidePanel, Toolbar] Add `border` prop to Toolbar and Sidebar (by [@vine77](https://github.com/vine77) in [#235](https://github.com/puppetlabs/design-system/pull/235)) +- Upgrade dependencies (by [@vine77](https://github.com/vine77) in [b91310b](https://github.com/puppetlabs/design-system/commit/b91310b722c509d90268b6efeae6692404074f0f)) # [5.19.0](https://github.com/puppetlabs/design-system/compare/@puppet/react-components@5.18.0...@puppet/react-components@5.19.0) (2020-03-13) diff --git a/packages/react-components/source/react/library/sidepanel/SidePanel.js b/packages/react-components/source/react/library/sidepanel/SidePanel.js index 79323dc8a..ef001839f 100644 --- a/packages/react-components/source/react/library/sidepanel/SidePanel.js +++ b/packages/react-components/source/react/library/sidepanel/SidePanel.js @@ -1,9 +1,11 @@ import React from 'react'; import PropTypes from 'prop-types'; +import classNames from 'classnames'; import Button from '../button'; import Heading from '../heading'; const propTypes = { + border: PropTypes.bool, className: PropTypes.string, children: PropTypes.node, closeButtonProps: PropTypes.shape({}), @@ -15,6 +17,7 @@ const propTypes = { }; const defaultProps = { + border: false, children: null, closeButtonProps: {}, open: true, @@ -28,6 +31,7 @@ const defaultProps = { * SidePanel may be used inside the rightmost Columns.Column. */ const SidePanel = ({ + border, children, open, title, @@ -49,7 +53,11 @@ const SidePanel = ({ return ( open && ( -
+
( -
{children}
+const Toolbar = ({ border, children, className }) => ( +
+ {children} +
); Toolbar.propTypes = propTypes; diff --git a/packages/react-components/source/react/library/toolbar/Toolbar.md b/packages/react-components/source/react/library/toolbar/Toolbar.md index 087bb65ff..cb26a1a8c 100644 --- a/packages/react-components/source/react/library/toolbar/Toolbar.md +++ b/packages/react-components/source/react/library/toolbar/Toolbar.md @@ -7,7 +7,7 @@ Toolbar acts as a container for tabs and buttons that is unified and compact. ```jsx import Button from '../button'; - +