(PUP-11515) Negative Lookbehind Regex Causes Duplicate Node

Before this commit, two nodes could collide due to the lookaround
Regex pattern. This issue arose because the regex was converted to
a regular string by ignoring characters other than a-z, 0-9, _, and -.

For example, /(?<!a)sync/ was converted to "__node_regexp__async,"
and /async/ was also converted to "__node_regexp__async," causing
an error that the node was already defined.

To prevent such duplication, this commit removes the lookarround
pattern from the regex at the end, ensuring a unique string in case
of lookarround pattern conflict.

For example, /(?<!a)sync/ will converted to "__node_regexp__sync"
removing (?<!a) while converting to the string.

Author: imaqsood

Diff for: lib/puppet/resource/type.rb

@@ -196,7 +196,7 @@ def instantiate_resource(scope, resource)
 
   def name
     if type == :node && name_is_regex?
-      "__node_regexp__#{@name.source.downcase.gsub(/[^-\w:.]/, '').sub(/^\.+/, '')}"
+      "__node_regexp__#{@name.source.downcase.gsub(/\(\?[^)]*\)/,'').gsub(/[^-\w:.]/, '').sub(/^\.+/, '')}"
     else
       @name
     end

Diff for: spec/integration/parser/node_spec.rb

@@ -85,6 +85,15 @@ class foo {
       end.not_to raise_error
     end
 
+    it 'does not raise an error with 2 regex node names are the same due to lookarround pattern' do
+      expect do
+        compile_to_catalog(<<-MANIFEST, Puppet::Node.new("async"))
+        node /(?<!a)sync/ { }
+        node /async/ { }
+        MANIFEST
+      end.not_to raise_error
+    end
+
     it 'errors when two nodes with regexes collide after some regex syntax is removed' do
       expect do
         compile_to_catalog(<<-MANIFEST)