(PUP-11841) Fix Style/RedundantFreeze

Now that all strings are frozen, it's redundant to call String#freeze.

Author: joshcooper

lib/hiera/scope.rb

@@ -4,13 +4,13 @@ class Hiera
   class Scope
     extend Forwardable
 
-    CALLING_CLASS = 'calling_class'.freeze
-    CALLING_CLASS_PATH = 'calling_class_path'.freeze
-    CALLING_MODULE = 'calling_module'.freeze
-    MODULE_NAME = 'module_name'.freeze
+    CALLING_CLASS = 'calling_class'
+    CALLING_CLASS_PATH = 'calling_class_path'
+    CALLING_MODULE = 'calling_module'
+    MODULE_NAME = 'module_name'
 
     CALLING_KEYS = [CALLING_CLASS, CALLING_CLASS_PATH, CALLING_MODULE].freeze
-    EMPTY_STRING = ''.freeze
+    EMPTY_STRING = ''
 
     attr_reader :real
 

lib/puppet/application/lookup.rb

@@ -7,7 +7,7 @@
 class Puppet::Application::Lookup < Puppet::Application
 
   RUN_HELP = _("Run 'puppet lookup --help' for more details").freeze
-  DEEP_MERGE_OPTIONS = '--knock-out-prefix, --sort-merged-arrays, and --merge-hash-arrays'.freeze
+  DEEP_MERGE_OPTIONS = '--knock-out-prefix, --sort-merged-arrays, and --merge-hash-arrays'
   TRUSTED_INFORMATION_FACTS = ["hostname", "domain", "fqdn", "clientcert"].freeze
 
   run_mode :server

lib/puppet/context/trusted_information.rb

@@ -110,12 +110,12 @@ def self.deep_freeze(object)
 
   def to_h
     {
-      'authenticated'.freeze => authenticated,
-      'certname'.freeze => certname,
-      'extensions'.freeze => extensions,
-      'hostname'.freeze => hostname,
-      'domain'.freeze => domain,
-      'external'.freeze => external,
+      'authenticated' => authenticated,
+      'certname' => certname,
+      'extensions' => extensions,
+      'hostname' => hostname,
+      'domain' => domain,
+      'external' => external,
     }.freeze
   end
 end

lib/puppet/face/help.rb

@@ -191,9 +191,9 @@ def all_application_summaries()
     end
   end
 
-  COMMON = 'Common:'.freeze
-  SPECIALIZED = 'Specialized:'.freeze
-  BLANK = "\n".freeze
+  COMMON = 'Common:'
+  SPECIALIZED = 'Specialized:'
+  BLANK = "\n"
   def available_application_names_special_sort()
     full_list = Puppet::Application.available_application_names
     a_list = full_list & %w{apply agent config help lookup module resource}

lib/puppet/file_system/path_pattern.rb

@@ -6,7 +6,7 @@ module Puppet::FileSystem
   class PathPattern
     class InvalidPattern < Puppet::Error; end
 
-    DOTDOT = '..'.freeze
+    DOTDOT = '..'
     ABSOLUTE_UNIX = /^\//
     ABSOLUTE_WINDOWS = /^[a-z]:/i
     CURRENT_DRIVE_RELATIVE_WINDOWS = /^\\/

lib/puppet/forge.rb

@@ -16,7 +16,7 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
 
   include Puppet::Forge::Errors
 
-  USER_AGENT = "PMT/1.1.1 (v3; Net::HTTP)".freeze
+  USER_AGENT = "PMT/1.1.1 (v3; Net::HTTP)"
 
   # From https://forgeapi.puppet.com/#!/release/getReleases
   MODULE_RELEASE_EXCLUSIONS=%w[readme changelog license uri module tags supported file_size downloads created_at updated_at deleted_at].join(',').freeze

lib/puppet/functions.rb

@@ -685,11 +685,11 @@ class Function3x < InternalFunction
     # Table of optimized parameter names - 0 to 5 parameters
     PARAM_NAMES = [
       [],
-      ['p0'.freeze].freeze,
-      ['p0'.freeze, 'p1'.freeze].freeze,
-      ['p0'.freeze, 'p1'.freeze, 'p2'.freeze].freeze,
-      ['p0'.freeze, 'p1'.freeze, 'p2'.freeze, 'p3'.freeze].freeze,
-      ['p0'.freeze, 'p1'.freeze, 'p2'.freeze, 'p3'.freeze, 'p4'.freeze].freeze,
+      ['p0'].freeze,
+      ['p0', 'p1'].freeze,
+      ['p0', 'p1', 'p2'].freeze,
+      ['p0', 'p1', 'p2', 'p3'].freeze,
+      ['p0', 'p1', 'p2', 'p3', 'p4'].freeze,
     ]
 
     # Creates an anonymous Function3x class that wraps a 3x function

lib/puppet/http.rb

@@ -8,8 +8,8 @@ module Puppet
   # @see Puppet::HTTP::Response
   # @api public
   module HTTP
-    ACCEPT_ENCODING = "gzip;q=1.0,deflate;q=0.6,identity;q=0.3".freeze
-    HEADER_PUPPET_VERSION = "X-Puppet-Version".freeze
+    ACCEPT_ENCODING = "gzip;q=1.0,deflate;q=0.6,identity;q=0.3"
+    HEADER_PUPPET_VERSION = "X-Puppet-Version"
 
     require_relative 'http/errors'
     require_relative 'http/site'

lib/puppet/http/service/ca.rb

@@ -7,7 +7,7 @@ class Puppet::HTTP::Service::Ca < Puppet::HTTP::Service
   HEADERS = { 'Accept' => 'text/plain' }.freeze
 
   # @return [String] default API for the ca service
-  API = '/puppet-ca/v1'.freeze
+  API = '/puppet-ca/v1'
 
   # Use `Puppet::HTTP::Session.route_to(:ca)` to create or get an instance of this class.
   #

lib/puppet/http/service/compiler.rb

@@ -5,7 +5,7 @@
 # @api public
 class Puppet::HTTP::Service::Compiler < Puppet::HTTP::Service
   # @return [String] Default API for the Compiler service
-  API = '/puppet/v3'.freeze
+  API = '/puppet/v3'
 
   # Use `Puppet::HTTP::Session.route_to(:puppet)` to create or get an instance of this class.
   #

lib/puppet/http/service/file_server.rb

@@ -7,7 +7,7 @@
 #
 class Puppet::HTTP::Service::FileServer < Puppet::HTTP::Service
   # @return [String] Default API for the FileServer service
-  API = '/puppet/v3'.freeze
+  API = '/puppet/v3'
 
   # @return [RegEx] RegEx used to determine if a path contains a leading slash
   PATH_REGEX = /^\//

lib/puppet/http/service/report.rb

@@ -6,7 +6,7 @@
 class Puppet::HTTP::Service::Report < Puppet::HTTP::Service
 
   # @return [String] Default API for the report service
-  API = '/puppet/v3'.freeze
+  API = '/puppet/v3'
 
   # Use `Puppet::HTTP::Session.route_to(:report)` to create or get an instance of this class.
   #

lib/puppet/http/session.rb

@@ -4,8 +4,8 @@
 # @api public
 class Puppet::HTTP::Session
   # capabilities for a site
-  CAP_LOCALES = 'locales'.freeze
-  CAP_JSON = 'json'.freeze
+  CAP_LOCALES = 'locales'
+  CAP_JSON = 'json'
 
   # puppet version where locales mount was added
   SUPPORTED_LOCALES_MOUNT_AGENT_VERSION = Gem::Version.new("5.3.4")

lib/puppet/network/format_handler.rb

@@ -6,7 +6,7 @@
 module Puppet::Network::FormatHandler
   class FormatError < Puppet::Error; end
 
-  ALL_MEDIA_TYPES = '*/*'.freeze
+  ALL_MEDIA_TYPES = '*/*'
 
   @formats = {}
 

lib/puppet/node.rb

@@ -22,7 +22,7 @@ class Puppet::Node
 
   attr_reader :server_facts
 
-  ENVIRONMENT = 'environment'.freeze
+  ENVIRONMENT = 'environment'
 
   def initialize_from_hash(data)
     @name       = data['name']       || (raise ArgumentError, _("No name provided in serialized data"))

lib/puppet/parser/compiler.rb

@@ -580,7 +580,7 @@ def set_node_parameters
     @topscope.set_facts(facts_hash)
   end
 
-  SETTINGS = 'settings'.freeze
+  SETTINGS = 'settings'
 
   def create_settings_scope
     settings_type = create_settings_type

lib/puppet/pops.rb

@@ -13,13 +13,13 @@ module Puppet
   module Pops
     EMPTY_HASH = {}.freeze
     EMPTY_ARRAY = [].freeze
-    EMPTY_STRING = ''.freeze
+    EMPTY_STRING = ''
 
     MAX_INTEGER =  0x7fffffffffffffff
     MIN_INTEGER = -0x8000000000000000
 
-    DOUBLE_COLON = '::'.freeze
-    USCORE = '_'.freeze
+    DOUBLE_COLON = '::'
+    USCORE = '_'
 
     require 'semantic_puppet'
 

lib/puppet/pops/evaluator/access_operator.rb

@@ -658,7 +658,7 @@ def access_PResourceType(o, scope, keys)
     return result_type_array ? result : result.pop
   end
 
-  NS = '::'.freeze
+  NS = '::'
 
   def access_PClassType(o, scope, keys)
     blamed = keys.size == 0 ? @semantic : @semantic.keys[0]

lib/puppet/pops/evaluator/closure.rb

@@ -164,7 +164,7 @@ def block_name
     'unsupported_block'
   end
 
-  CLOSURE_NAME = 'lambda'.freeze
+  CLOSURE_NAME = 'lambda'
 
   # @api public
   def closure_name()

lib/puppet/pops/evaluator/deferred_resolver.rb

@@ -17,8 +17,8 @@ def resolve
 # Utility class to help resolve instances of Puppet::Pops::Types::PDeferredType::Deferred
 #
 class DeferredResolver
-  DOLLAR = '$'.freeze
-  DIG    = 'dig'.freeze
+  DOLLAR = '$'
+  DIG    = 'dig'
 
   # Resolves and replaces all Deferred values in a catalog's resource attributes
   # found as direct values or nested inside Array, Hash or Sensitive values.

lib/puppet/pops/evaluator/evaluator_impl.rb

@@ -34,7 +34,7 @@ class EvaluatorImpl
   include Runtime3Support
   include ExternalSyntaxSupport
 
-  COMMA_SEPARATOR = ', '.freeze
+  COMMA_SEPARATOR = ', '
 
   # Reference to Issues name space makes it easier to refer to issues
   # (Issues are shared with the validator).

lib/puppet/pops/evaluator/json_strict_literal_evaluator.rb

@@ -20,7 +20,7 @@
 class Puppet::Pops::Evaluator::JsonStrictLiteralEvaluator
   #include Puppet::Pops::Utils
 
-  COMMA_SEPARATOR = ', '.freeze
+  COMMA_SEPARATOR = ', '
 
   def initialize
     @@literal_visitor ||= Puppet::Pops::Visitor.new(self, "literal", 0, 0)

lib/puppet/pops/evaluator/literal_evaluator.rb

@@ -17,7 +17,7 @@ module Evaluator
 #
 class LiteralEvaluator
 
-  COMMA_SEPARATOR = ', '.freeze
+  COMMA_SEPARATOR = ', '
 
   def initialize
     @@literal_visitor ||= Visitor.new(self, "literal", 0, 0)

lib/puppet/pops/evaluator/runtime3_resource_support.rb

@@ -4,7 +4,7 @@ module Evaluator
 
 # @api private
 module Runtime3ResourceSupport
-  CLASS_STRING = 'class'.freeze
+  CLASS_STRING = 'class'
 
   def self.create_resources(file, line, scope, virtual, exported, type_name, resource_titles, evaluated_parameters)
 

lib/puppet/pops/evaluator/runtime3_support.rb

@@ -8,7 +8,7 @@ module Evaluator
 # @api private
 module Runtime3Support
 
-  NAME_SPACE_SEPARATOR = '::'.freeze
+  NAME_SPACE_SEPARATOR = '::'
 
   # Fails the evaluation of _semantic_ with a given issue.
   #

lib/puppet/pops/loader/loader.rb

@@ -23,8 +23,8 @@
 module Puppet::Pops
 module Loader
 
-ENVIRONMENT = 'environment'.freeze
-ENVIRONMENT_PRIVATE = 'environment private'.freeze
+ENVIRONMENT = 'environment'
+ENVIRONMENT_PRIVATE = 'environment private'
 
 class Loader
   attr_reader :environment, :loader_name

lib/puppet/pops/loader/loader_paths.rb

@@ -118,7 +118,7 @@ def instantiator
   end
 
   class RubySmartPath < SmartPath
-    EXTENSION = '.rb'.freeze
+    EXTENSION = '.rb'
 
     def extension
       EXTENSION
@@ -134,7 +134,7 @@ def effective_path(typed_name, start_index_in_name)
   # path (which is a reference to its 'lib' directory.
   #
   class PuppetSmartPath < SmartPath
-    EXTENSION = '.pp'.freeze
+    EXTENSION = '.pp'
 
     def extension
       EXTENSION
@@ -194,7 +194,7 @@ def instantiator
   end
 
   class FunctionPathPP < PuppetSmartPath
-    FUNCTION_PATH_PP = 'functions'.freeze
+    FUNCTION_PATH_PP = 'functions'
 
     def relative_path
       FUNCTION_PATH_PP
@@ -219,7 +219,7 @@ def instantiator
   end
 
   class TypePathPP < PuppetSmartPath
-    TYPE_PATH_PP = 'types'.freeze
+    TYPE_PATH_PP = 'types'
 
     def relative_path
       TYPE_PATH_PP
@@ -233,7 +233,7 @@ def instantiator
   # TaskPath is like PuppetSmartPath but it does not use an extension and may
   # match more than one path with one name
   class TaskPath < PuppetSmartPath
-    TASKS_PATH = 'tasks'.freeze
+    TASKS_PATH = 'tasks'
     FORBIDDEN_EXTENSIONS = %w{.conf .md}.freeze
 
     def extension
@@ -286,7 +286,7 @@ def is_task_name?(name)
   end
 
   class ResourceTypeImplPP < PuppetSmartPath
-    RESOURCE_TYPES_PATH_PP = '.resource_types'.freeze
+    RESOURCE_TYPES_PATH_PP = '.resource_types'
 
     def relative_path
       RESOURCE_TYPES_PATH_PP
@@ -313,8 +313,8 @@ def effective_path(typed_name, start_index_in_name)
 
   class PlanPath < PuppetSmartPath
     PLAN_PATH = File.join('plans')
-    PP_EXT = '.pp'.freeze
-    YAML_EXT = '.yaml'.freeze
+    PP_EXT = '.pp'
+    YAML_EXT = '.yaml'
 
     def initialize(loader)
       super

lib/puppet/pops/loader/module_loaders.rb

@@ -22,7 +22,7 @@ module Loader
 module ModuleLoaders
 
   # Wildcard module name for module loaders, makes loading possible from any namespace.
-  NAMESPACE_WILDCARD = '*'.freeze
+  NAMESPACE_WILDCARD = '*'
 
   # This is exactly the same as the #system_loader_from method, but the argument for path is changed to
   # location where pluginsync stores functions. It also accepts definitions in any namespace since pluginsync

lib/puppet/pops/loader/ruby_legacy_function_instantiator.rb

@@ -4,7 +4,7 @@
 #
 require 'ripper'
 class Puppet::Pops::Loader::RubyLegacyFunctionInstantiator
-  UNKNOWN = '<unknown>'.freeze
+  UNKNOWN = '<unknown>'
 
   # Produces an instance of the Function class with the given typed_name, or fails with an error if the
   # given ruby source does not produce this instance when evaluated.

lib/puppet/pops/loader/typed_name.rb

@@ -27,7 +27,7 @@ def initialize(type, name, name_authority = Pcore::RUNTIME_NAME_AUTHORITY)
     @name_parts = parts.freeze
 
     # Use a frozen compound key for the hash and comparison. Most varying part first
-    @compound_name = "#{@name}/#{@type}/#{@name_authority}".freeze
+    @compound_name = "#{@name}/#{@type}/#{@name_authority}"
     @hash = @compound_name.hash
     freeze
   end

lib/puppet/pops/lookup.rb

@@ -4,8 +4,8 @@
 #
 module Puppet::Pops
 module Lookup
-  LOOKUP_OPTIONS = 'lookup_options'.freeze
-  GLOBAL = '__global__'.freeze
+  LOOKUP_OPTIONS = 'lookup_options'
+  GLOBAL = '__global__'
 
   # Performs a lookup in the configured scopes and optionally merges the default.
   #