From aa8dc298bb576df973ad137b5da603158432ef5f Mon Sep 17 00:00:00 2001 From: Shubham Shinde Date: Tue, 21 May 2024 23:07:27 +0530 Subject: [PATCH] Bump github actions JRuby to 9.3.14 and remove jruby's failure expectation - Jruby 9.3.14.0 handles glob correctly, so remove the pending test for jruby. --- .github/workflows/rspec_tests.yaml | 2 +- spec/unit/file_system/path_pattern_spec.rb | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/rspec_tests.yaml b/.github/workflows/rspec_tests.yaml index 7c620e77b43..abd91335943 100644 --- a/.github/workflows/rspec_tests.yaml +++ b/.github/workflows/rspec_tests.yaml @@ -20,7 +20,7 @@ jobs: - {os: ubuntu-latest, ruby: '2.6'} - {os: ubuntu-latest, ruby: '2.7'} - {os: ubuntu-latest, ruby: '3.0'} - - {os: ubuntu-latest, ruby: 'jruby-9.3.9.0'} + - {os: ubuntu-latest, ruby: 'jruby-9.3.14.0'} - {os: windows-2019, ruby: '2.5'} - {os: windows-2019, ruby: '2.6'} - {os: windows-2019, ruby: '2.7'} diff --git a/spec/unit/file_system/path_pattern_spec.rb b/spec/unit/file_system/path_pattern_spec.rb index 8948dab9497..cbecd07912a 100644 --- a/spec/unit/file_system/path_pattern_spec.rb +++ b/spec/unit/file_system/path_pattern_spec.rb @@ -134,9 +134,6 @@ end it 'globs wildcard patterns properly' do - # See PUP-11788 and https://github.com/jruby/jruby/issues/7836. - pending 'JRuby does not properly handle Dir.glob' if Puppet::Util::Platform.jruby? - dir = tmpdir('globtest') create_file_in(dir, 'foo.pp') create_file_in(dir, 'foo.pp.pp')