(CONT-790) Rubocop Manual Fixes 3 - RSpec/ContextWording

Author: david22swan

.rubocop_todo.yml

@@ -6,15 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 7
-# Configuration parameters: Prefixes, AllowedPatterns.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Exclude:
-    - 'spec/acceptance/integration_ntp_spec.rb'
-    - 'spec/classes/contains_spec.rb'
-    - 'spec/classes/ntp_spec.rb'
-
 # Offense count: 9
 # Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:

spec/acceptance/integration_ntp_spec.rb

@@ -5,7 +5,7 @@
 require 'pry'
 
 describe 'we are able to setup an ntp server, and connect a client to it', :integration do
-  context 'set up the server' do
+  context 'when setting up the server' do
     before(:all) { change_target_host('ntpserver') }
     after(:all) { reset_target_host }
 
@@ -22,7 +22,7 @@ class { 'ntp': }
     end
   end
 
-  context 'set up the client' do
+  context 'when setting up the client' do
     before(:all) { change_target_host('ntpclient') }
     after(:all) { reset_target_host }
 

spec/classes/contains_spec.rb

@@ -13,7 +13,7 @@
   end
 
   on_supported_os.each do |os, f|
-    context "on #{os}" do
+    context "when on #{os}" do
       let(:facts) do
         f.merge(super())
       end

spec/classes/ntp_spec.rb

@@ -14,7 +14,7 @@
       end
     end
 
-    context "on #{os}" do
+    context "when on #{os}" do
       let(:facts) do
         f.merge(super())
       end
@@ -102,7 +102,7 @@
           end
         end
 
-        context 'config_dir' do
+        context 'with config_dir' do
           context 'when set to custom dir' do
             let(:params) do
               {
@@ -120,7 +120,7 @@
           end
         end
 
-        context 'config_file_mode' do
+        context 'with config_file_mode' do
           context 'when set to custom mode' do
             let(:params) do
               {
@@ -134,7 +134,7 @@
           end
         end
 
-        context 'default pool servers' do
+        context 'with default pool servers' do
           case f[:os]['family']
           when 'RedHat'
             it 'uses the centos ntp servers' do