Change validation to use data type annotations

This requires more work to add depreciations to the current hodge-podge,
to tighten down what is allowed. Many of the unchecked edge-cases will
result in a broken ntp config anyways, but just fixing it would elevate
issues in this area from broken ntp service to broken catalog.

Author: DavidS

.fixtures.yml

@@ -1,6 +1,8 @@
 fixtures:
   repositories:
-    "stdlib": "git://github.com/puppetlabs/puppetlabs-stdlib.git"
+    stdlib:
+      repo: 'git://github.com/puppetlabs/puppetlabs-stdlib.git'
+      ref: 'experiments/validate-compat-type-aliases'
   symlinks:
     "ntp": "#{source_dir}"
     "my_ntp": "#{source_dir}/spec/fixtures/my_ntp"

manifests/init.pp

@@ -1,56 +1,56 @@
 class ntp (
   $autoupdate,
-  $broadcastclient,
-  $config,
-  $config_dir,
+  Stdlib::Compat::Bool $broadcastclient,
+  Stdlib::Compat::Absolute_path $config,
+  Variant[Any, Undef, Stdlib::Compat::Absolute_path] $config_dir,
   $config_file_mode,
-  $config_template,
-  $disable_auth,
-  $disable_dhclient,
-  $disable_kernel,
-  $disable_monitor,
-  $fudge,
-  $driftfile,
-  $leapfile,
-  $logfile,
-  $iburst_enable,
-  $keys,
-  $keys_enable,
+  Stdlib::Compat::String $config_template,
+  Stdlib::Compat::Bool $disable_auth,
+  Stdlib::Compat::Bool $disable_dhclient,
+  Stdlib::Compat::Bool $disable_kernel,
+  Stdlib::Compat::Bool $disable_monitor,
+  Stdlib::Compat::Array $fudge,
+  Stdlib::Compat::Absolute_path $driftfile,
+  Variant[Boolean, Undef, Stdlib::Compat::Absolute_path] $leapfile,
+  Variant[Boolean, Undef, Stdlib::Compat::Absolute_path] $logfile,
+  Stdlib::Compat::Bool $iburst_enable,
+  Stdlib::Compat::Array $keys,
+  Stdlib::Compat::Bool $keys_enable,
   $keys_file,
-  $keys_controlkey,
-  $keys_requestkey,
-  $keys_trusted,
-  $minpoll,
-  $maxpoll,
-  $package_ensure,
-  $package_manage,
-  $package_name,
-  $panic                  = $ntp::params::panic,
-  $peers,
-  $preferred_servers,
-  $restrict,
-  $interfaces,
+  Variant[Pattern['^\d+$'], Pattern['']] $keys_controlkey,
+  Variant[Pattern['^\d+$'], Pattern['']] $keys_requestkey,
+  Stdlib::Compat::Array $keys_trusted,
+  Variant[Boolean, Undef, Stdlib::Compat::Numeric] $minpoll,
+  Variant[Boolean, Undef, Stdlib::Compat::Numeric] $maxpoll,
+  Stdlib::Compat::String $package_ensure,
+  Stdlib::Compat::Bool $package_manage,
+  Stdlib::Compat::Array $package_name,
+  Variant[Boolean, Undef, Stdlib::Compat::Numeric] $panic = $ntp::params::panic,
+  Stdlib::Compat::Array $peers,
+  Stdlib::Compat::Array $preferred_servers,
+  Stdlib::Compat::Array $restrict,
+  Stdlib::Compat::Array $interfaces,
   $interfaces_ignore,
-  $servers,
-  $service_enable,
-  $service_ensure,
-  $service_manage,
-  $service_name,
+  Stdlib::Compat::Array $servers,
+  Stdlib::Compat::Bool $service_enable,
+  Stdlib::Compat::String $service_ensure,
+  Stdlib::Compat::Bool $service_manage,
+  Stdlib::Compat::String $service_name,
   $service_provider,
-  $stepout,
-  $step_tickers_file,
-  $step_tickers_template,
-  $tinker                 = $ntp::params::tinker,
-  $tos,
-  $tos_minclock,
-  $tos_minsane,
-  $tos_floor,
-  $tos_ceiling,
-  $tos_cohort,
-  $udlc,
+  Variant[Boolean, Undef, Stdlib::Compat::Numeric] $stepout,
+  Variant[Boolean, Undef, Stdlib::Compat::String] $step_tickers_file,
+  Variant[Any, Undef, Stdlib::Compat::String] $step_tickers_template,
+  Stdlib::Compat::Bool $tinker = $ntp::params::tinker,
+  Stdlib::Compat::Bool $tos,
+  Variant[Boolean, Undef, Stdlib::Compat::Numeric] $tos_minclock,
+  Variant[Boolean, Undef, Stdlib::Compat::Numeric] $tos_minsane,
+  Variant[Boolean, Undef, Stdlib::Compat::Numeric] $tos_floor,
+  Variant[Boolean, Undef, Stdlib::Compat::Numeric] $tos_ceiling,
+  Variant[Boolean, Undef, Pattern['^[0|1]$']] $tos_cohort,
+  Stdlib::Compat::Bool $udlc,
   $udlc_stratum,
-  $ntpsigndsocket,
-  $authprov,
+  Variant[Boolean, Undef, Stdlib::Compat::Absolute_path] $ntpsigndsocket,
+  Variant[Any, Undef, Stdlib::Compat::String] $authprov,
 ) inherits ntp::params {
 
   validate_bool($broadcastclient)