(FM-5361) Remove all the legacy/backwards-compat/deprecation logic

This finishes the move to a cleaner puppet4 interface. Since this is
a breaking change, it also bumps the major version. Users of the previous
version who were running without receiving any deprecation warnings can
use this version without any changes.

Author: DavidS

.fixtures.yml

@@ -3,6 +3,8 @@ fixtures:
     stdlib:
       repo: 'git://github.com/puppetlabs/puppetlabs-stdlib.git'
       ref: 'experiments/validate-compat-type-aliases'
+    tea:
+      repo: 'git://github.com/voxpupuli/puppet-tea.git'
   symlinks:
     "ntp": "#{source_dir}"
     "my_ntp": "#{source_dir}/spec/fixtures/my_ntp"

manifests/init.pp

@@ -1,187 +1,56 @@
 class ntp (
-  Any $autoupdate,
-  Variant[Boolean, Stdlib::Compat::Bool] $broadcastclient,
-  Variant[Tea::Absolutepath, Stdlib::Compat::Absolute_path] $config,
-  Variant[Optional[Tea::Absolutepath], Any, Undef, Stdlib::Compat::Absolute_path] $config_dir,
-  Variant[String, Any] $config_file_mode,
-  Variant[String[1], Stdlib::Compat::String] $config_template,
-  Variant[Boolean, Stdlib::Compat::Bool] $disable_auth,
-  Variant[Boolean, Stdlib::Compat::Bool] $disable_dhclient,
-  Variant[Boolean, Stdlib::Compat::Bool] $disable_kernel,
-  Variant[Boolean, Stdlib::Compat::Bool] $disable_monitor,
-  Variant[Optional[Array[String]], Stdlib::Compat::Array] $fudge,
-  Variant[Tea::Absolutepath, Stdlib::Compat::Absolute_path] $driftfile,
-  Variant[Optional[Tea::Absolutepath], Boolean, Undef, Stdlib::Compat::Absolute_path] $leapfile,
-  Variant[Optional[Tea::Absolutepath], Boolean, Undef, Stdlib::Compat::Absolute_path] $logfile,
-  Variant[Boolean, Stdlib::Compat::Bool] $iburst_enable,
-  Variant[Array[String], Stdlib::Compat::Array] $keys,
-  Variant[Boolean, Stdlib::Compat::Bool] $keys_enable,
-  Variant[Tea::Absolutepath, Any] $keys_file,
-  Variant[Optional[Ntp::Key_id], Pattern['^\d+$'], Pattern['']] $keys_controlkey,
-  Variant[Optional[Ntp::Key_id], Pattern['^\d+$'], Pattern['']] $keys_requestkey,
-  Variant[Optional[Array[Ntp::Key_id]], Stdlib::Compat::Array] $keys_trusted,
-  Variant[Optional[Ntp::Poll_interval], Boolean, Undef, Stdlib::Compat::Numeric] $minpoll,
-  Variant[Optional[Ntp::Poll_interval], Boolean, Undef, Stdlib::Compat::Numeric] $maxpoll,
-  Variant[String, Stdlib::Compat::String] $package_ensure,
-  Variant[Boolean, Stdlib::Compat::Bool] $package_manage,
-  Variant[Array[String], Stdlib::Compat::Array] $package_name,
-  Variant[Boolean, Undef, Stdlib::Compat::Numeric] $panic = $ntp::params::panic,
-  Variant[Array[String], Stdlib::Compat::Array] $peers,
-  Variant[Array[String], Stdlib::Compat::Array] $preferred_servers,
-  Variant[Array[String], Stdlib::Compat::Array] $restrict,
-  Variant[Array[String], Stdlib::Compat::Array] $interfaces,
-  Variant[Array[String], Any] $interfaces_ignore,
-  Variant[Array[String], Stdlib::Compat::Array] $servers,
-  Variant[Boolean, Stdlib::Compat::Bool] $service_enable,
-  Variant[String, Stdlib::Compat::String] $service_ensure,
-  Variant[Boolean, Stdlib::Compat::Bool] $service_manage,
-  Variant[String, Stdlib::Compat::String] $service_name,
-  Variant[String, Any] $service_provider,
-  Variant[Optional[Integer[0, 65535]], Boolean, Undef, Stdlib::Compat::Numeric] $stepout,
-  Variant[Optional[Tea::Absolutepath], Boolean, Undef, Stdlib::Compat::String] $step_tickers_file,
-  Variant[Optional[String], Any, Undef, Stdlib::Compat::String] $step_tickers_template,
-  Variant[Boolean, Stdlib::Compat::Bool] $tinker = $ntp::params::tinker,
-  Variant[Boolean, Stdlib::Compat::Bool] $tos,
-  Variant[Optional[Integer[1]], Boolean, Undef, Stdlib::Compat::Numeric] $tos_minclock,
-  Variant[Optional[Integer[1]], Boolean, Undef, Stdlib::Compat::Numeric] $tos_minsane,
-  Variant[Optional[Integer[1]], Boolean, Undef, Stdlib::Compat::Numeric] $tos_floor,
-  Variant[Optional[Integer[1]], Boolean, Undef, Stdlib::Compat::Numeric] $tos_ceiling,
-  Variant[Variant[Boolean, Integer[0,1]], Boolean, Undef, Pattern['^[0|1]$']] $tos_cohort,
-  Variant[Boolean, Stdlib::Compat::Bool] $udlc,
-  Variant[Optional[Integer[1,15]], Any] $udlc_stratum,
-  Variant[Optional[Tea::Absolutepath], Boolean, Undef, Stdlib::Compat::Absolute_path] $ntpsigndsocket,
-  Variant[Optional[String], Any, Undef, Stdlib::Compat::String] $authprov,
+  Boolean $broadcastclient,
+  Tea::Absolutepath $config,
+  Optional[Tea::Absolutepath] $config_dir,
+  String $config_file_mode,
+  String[1] $config_template,
+  Boolean $disable_auth,
+  Boolean $disable_dhclient,
+  Boolean $disable_kernel,
+  Boolean $disable_monitor,
+  Optional[Array[String]] $fudge,
+  Tea::Absolutepath $driftfile,
+  Optional[Tea::Absolutepath] $leapfile,
+  Optional[Tea::Absolutepath] $logfile,
+  Boolean $iburst_enable,
+  Array[String] $keys,
+  Boolean $keys_enable,
+  Tea::Absolutepath $keys_file,
+  Optional[Ntp::Key_id] $keys_controlkey,
+  Optional[Ntp::Key_id] $keys_requestkey,
+  Optional[Array[Ntp::Key_id]] $keys_trusted,
+  Optional[Ntp::Poll_interval] $minpoll,
+  Optional[Ntp::Poll_interval] $maxpoll,
+  String $package_ensure,
+  Boolean $package_manage,
+  Array[String] $package_name,
+  Boolean $panic                                  = $ntp::params::panic,
+  Array[String] $peers,
+  Array[String] $preferred_servers,
+  Array[String] $restrict,
+  Array[String] $interfaces,
+  Array[String] $interfaces_ignore,
+  Array[String] $servers,
+  Boolean $service_enable,
+  String $service_ensure,
+  Boolean $service_manage,
+  String $service_name,
+  String $service_provider,
+  Optional[Integer[0, 65535]] $stepout,
+  Optional[Tea::Absolutepath] $step_tickers_file,
+  Optional[String] $step_tickers_template,
+  Boolean $tinker                                 = $ntp::params::tinker,
+  Boolean $tos,
+  Optional[Integer[1]] $tos_minclock,
+  Optional[Integer[1]] $tos_minsane,
+  Optional[Integer[1]] $tos_floor,
+  Optional[Integer[1]] $tos_ceiling,
+  Variant[Boolean, Integer[0,1]] $tos_cohort,
+  Boolean $udlc,
+  Optional[Integer[1,15]] $udlc_stratum,
+  Optional[Tea::Absolutepath] $ntpsigndsocket,
+  Optional[String] $authprov,
 ) inherits ntp::params {
-
-  validate_legacy(Boolean, 'bool', $broadcastclient)
-  validate_legacy(Tea::Absolutepath, 'absolute_path', $config)
-
-  assert_type(String, $config_file_mode) |$expected, $actual| {
-    deprecation("ntp::config_file_mode should be '${expected}', not '${actual}'")
-  }
-
-  validate_legacy(String[1], 'string', $config_template)
-  validate_legacy(Boolean, 'bool', $disable_auth)
-  validate_legacy(Boolean, 'bool', $disable_dhclient)
-  validate_legacy(Boolean, 'bool', $disable_kernel)
-  validate_legacy(Boolean, 'bool', $disable_monitor)
-  validate_legacy(Tea::Absolutepath, 'absolute_path', $driftfile)
-
-  if $logfile { validate_legacy(Optional[Tea::Absolutepath], 'absolute_path', $logfile) }
-  elsif $logfile == undef { }
-  else { deprecation('ntp::logfile is false, but should be undef') }
-
-  if $ntpsigndsocket { validate_legacy(Optional[Tea::Absolutepath], 'absolute_path', $ntpsigndsocket) }
-  elsif $ntpsigndsocket == undef { }
-  else { deprecation('ntp::ntpsigndsocket is false, but should be undef') }
-
-  if $leapfile { validate_legacy(Optional[Tea::Absolutepath], 'absolute_path', $leapfile) }
-  elsif $leapfile == undef { }
-  else { deprecation('ntp::leapfile is false, but should be undef') }
-
-  validate_legacy(Boolean, 'bool', $iburst_enable)
-  validate_legacy(Array[String], 'array', $keys)
-  validate_legacy(Boolean, 'bool', $keys_enable)
-  validate_legacy(Optional[Ntp::Key_id], 're', $keys_controlkey, ['^\d+$', ''])
-  validate_legacy(Optional[Ntp::Key_id], 're', $keys_requestkey, ['^\d+$', ''])
-  validate_legacy(Optional[Array[Ntp::Key_id]], 'array', $keys_trusted)
-  if $minpoll { validate_legacy(Optional[Ntp::Poll_interval], 'numeric', $minpoll, 16, 3) }
-  elsif $minpoll == undef { }
-  else { deprecation('ntp::minpoll is false, but should be undef') }
-
-  if $maxpoll { validate_legacy(Optional[Ntp::Poll_interval], 'numeric', $maxpoll, 16, 3) }
-  elsif $maxpoll == undef { }
-  else { deprecation('ntp::maxpoll is false, but should be undef') }
-
-  validate_legacy(String, 'string', $package_ensure)
-  validate_legacy(Boolean, 'bool', $package_manage)
-  validate_legacy(Array[String], 'array', $package_name)
-  if $panic { validate_legacy(Optional[Integer[0]], 'numeric', $panic, 65535, 0) }
-  elsif $panic == undef { }
-  else { deprecation('ntp::panic is false, but should be undef') }
-
-  validate_legacy(Array[String], 'array', $preferred_servers)
-  validate_legacy(Array[String], 'array', $restrict)
-  validate_legacy(Array[String], 'array', $interfaces)
-  assert_type(Array[String], $interfaces_ignore) |$expected, $actual| {
-    deprecation("ntp::interfaces_ignore should be '${expected}', not '${actual}'")
-  }
-  validate_legacy(Array[String], 'array', $servers)
-  validate_legacy(Array[String], 'array', $fudge)
-  validate_legacy(Boolean, 'bool', $service_enable)
-  validate_legacy(String, 'string', $service_ensure)
-  validate_legacy(Boolean, 'bool', $service_manage)
-  validate_legacy(String, 'string', $service_name)
-  assert_type(String, $service_provider) |$expected, $actual| {
-    deprecation("ntp::service_provider should be '${expected}', not '${actual}'")
-  }
-
-  if $stepout { validate_legacy(Optional[Integer[0, 65535]], 'numeric', $stepout, 65535, 0) }
-  elsif $stepout == undef { }
-  else { deprecation('ntp::stepout is false, but should be undef') }
-
-  if $step_tickers_file {
-    validate_legacy(Optional[Tea::Absolutepath], 'string', $step_tickers_file)
-    validate_legacy(Optional[String], 'string', $step_tickers_template)
-  }
-  elsif $step_tickers_file == undef { }
-  else { deprecation('ntp::step_tickers_file is false, but should be undef') }
-
-  # In cases where $step_tickers_file evaluated to false, anything could have been
-  # passed to $step_tickers_template. This deprecation removes that hole.
-  assert_type(Optional[String], $step_tickers_template) |$expected, $actual| {
-    deprecation("ntp::step_tickers_template should be '${expected}', not '${actual}'")
-  }
-
-  validate_legacy(Boolean, 'bool', $tinker)
-  validate_legacy(Boolean, 'bool', $tos)
-  if $tos_minclock { validate_legacy(Optional[Integer[1]], 'numeric', $tos_minclock) }
-  elsif $tos_minclock == undef { }
-  else { deprecation('ntp::tos_minclock is false, but should be undef') }
-
-  if $tos_minsane { validate_legacy(Optional[Integer[1]], 'numeric', $tos_minsane) }
-  elsif $tos_minsane == undef { }
-  else { deprecation('ntp::tos_minsane is false, but should be undef') }
-
-  if $tos_floor { validate_legacy(Optional[Integer[1]], 'numeric', $tos_floor) }
-  elsif $tos_floor == undef { }
-  else { deprecation('ntp::tos_floor is false, but should be undef') }
-
-  if $tos_ceiling { validate_legacy(Optional[Integer[1]], 'numeric', $tos_ceiling) }
-  elsif $tos_ceiling == undef { }
-  else { deprecation('ntp::tos_ceiling is false, but should be undef') }
-
-  if $tos_cohort { validate_legacy(Variant[Boolean, Integer[0,1]], 're', $tos_cohort, '^[0|1]$', "Must be 0 or 1, got: ${tos_cohort}") }
-  elsif $tos_cohort == undef { }
-  elsif $tos_cohort == false { }
-  else {
-    # No idea what else could come through here, but better safe than sorry, and
-    # with the next major release, this will go away, anyways.
-    assert_type(Optional[Variant[Boolean, Integer[0,1]]], $tos_cohort) |$expected, $actual| {
-      deprecation("ntp::tos_cohort should be '${expected}', not '${actual}'")
-    }
-  }
-
-  validate_legacy(Boolean, 'bool', $udlc)
-  assert_type(Optional[Integer[1,15]], $udlc_stratum) |$expected, $actual| {
-    deprecation("ntp::udlc_stratum should be '${expected}', not '${actual}'")
-  }
-
-  validate_legacy(Array[String], 'array', $peers)
-  if $authprov { validate_legacy(Optional[String], 'string', $authprov) }
-  elsif $authprov == undef { }
-  else { deprecation('ntp::authprov is false, but should be undef') }
-
-
-  if $config_dir { validate_legacy(Optional[Tea::Absolutepath], 'absolute_path', $config_dir) }
-  elsif $config_dir == undef { }
-  else { deprecation('ntp::config_dir is false, but should be undef') }
-
-
-  if $autoupdate {
-    notice('ntp: autoupdate parameter has been deprecation and replaced with package_ensure. Set package_ensure to latest for the same behavior as autoupdate => true.')
-  }
-
   # Anchor this as per #8040 - this ensures that classes won't float off and
   # mess everything up.  You can read about this at:
   # http://docs.puppetlabs.com/puppet/2.7/reference/lang_containment.html#known-issues

metadata.json

@@ -1,6 +1,6 @@
 {
   "name": "puppetlabs-ntp",
-  "version": "99.2.0",
+  "version": "100.2.0",
   "author": "Puppet Labs",
   "summary": "Installs, configures, and manages the NTP service.",
   "license": "Apache-2.0",