Merge pull request #172 from hunner/feature-solaris

(MODULES-213) Solaris 10 support

Author: Ashley Penney

README.markdown

@@ -221,6 +221,8 @@ The module has been tested on:
 * Gentoo
 * Arch Linux
 * FreeBSD
+* Solaris 10
+* AIX 5.3, 6.1, 7.1
 
 Testing on other platforms has been light and cannot be guaranteed. 
 

manifests/install.pp

@@ -1,9 +1,8 @@
 #
 class ntp::install inherits ntp {
 
-  package { 'ntp':
+  package { $package_name:
     ensure => $package_ensure,
-    name   => $package_name,
   }
 
 }

manifests/params.pp

@@ -132,6 +132,25 @@
         '2.pool.ntp.org',
       ]
     }
+    'Solaris': {
+      $config       = '/etc/inet/ntp.conf'
+      $driftfile    = '/var/ntp/ntp.drift'
+      $keys_file    = '/etc/inet/ntp.keys'
+      $package_name = [ 'SUNWntpr', 'SUNWntpu' ]
+      $restrict     = [
+        'default kod nomodify notrap nopeer noquery',
+        '-6 default kod nomodify notrap nopeer noquery',
+        '127.0.0.1',
+        '-6 ::1',
+      ]
+      $service_name = 'network/ntp'
+      $servers      = [
+        '0.pool.ntp.org',
+        '1.pool.ntp.org',
+        '2.pool.ntp.org',
+        '3.pool.ntp.org',
+      ]
+    }
     # Gentoo was added as its own $::osfamily in Facter 1.7.0
     'Gentoo': {
       $config          = '/etc/ntp.conf'

metadata.json

@@ -50,6 +50,12 @@
         "14.04"
       ]
     },
+    {
+      "operatingsystem": "Solaris",
+      "operatingsystemrelease": [
+        "10"
+      ]
+    },
     {
       "operatingsystem": "AIX",
       "operatingsystemrelease": [

spec/acceptance/ntp_config_spec.rb

@@ -18,6 +18,8 @@
   when 'Gentoo'
     line = '0.gentoo.pool.ntp.org'
   end
+when 'Solaris'
+  line = '0.pool.ntp.org'
 when 'AIX'
   line = '0.debian.pool.ntp.org iburst'
 end

spec/acceptance/ntp_install_spec.rb

@@ -14,6 +14,8 @@
   end
 when 'AIX'
   packagename = 'bos.net.tcp.client'
+when 'Solaris'
+  packagename = ['SUNWntpr','SUNWntpu']
 else
   packagename = 'ntp'
 end
@@ -25,7 +27,9 @@ class { 'ntp': }
     }, :catch_failures => true)
   end
 
-  describe package(packagename) do
-    it { should be_installed }
+  Array(packagename).each do |package|
+    describe package(package) do
+      it { should be_installed }
+    end
   end
 end

spec/acceptance/ntp_parameters_spec.rb

@@ -14,6 +14,8 @@
   end
 when 'AIX'
   packagename = 'bos.net.tcp.client'
+when 'Solaris'
+  packagename = ['SUNWntpr','SUNWntpu']
 else
   packagename = 'ntp'
 end
@@ -109,14 +111,16 @@ class { 'ntp':
       pp = <<-EOS
       class { 'ntp':
         package_ensure => present,
-        package_name   => ['#{packagename}'],
+        package_name   => #{Array(packagename).inspect},
       }
       EOS
       apply_manifest(pp, :catch_failures => true)
     end
 
-    describe package(packagename) do
-      it { should be_installed }
+    Array(packagename).each do |package|
+      describe package(package) do
+        it { should be_installed }
+      end
     end
   end
 

spec/acceptance/ntp_service_spec.rb

@@ -3,6 +3,8 @@
 case fact('osfamily')
 when 'RedHat', 'FreeBSD', 'Linux', 'Gentoo'
   servicename = 'ntpd'
+when 'Solaris'
+  servicename = 'network/ntp'
 when 'AIX'
   servicename = 'xntpd'
 else

spec/classes/ntp_spec.rb

@@ -121,8 +121,7 @@
         let(:params) {{ :package_ensure => 'present', :package_name => ['ntp'], }}
 
         it { should contain_package('ntp').with(
-          :ensure => 'present',
-          :name   => 'ntp'
+          :ensure => 'present'
         )}
 
         describe 'should allow package ensure to be overridden' do
@@ -132,7 +131,7 @@
 
         describe 'should allow the package name to be overridden' do
           let(:params) {{ :package_ensure => 'present', :package_name => ['hambaby'] }}
-          it { should contain_package('ntp').with_name('hambaby') }
+          it { should contain_package('hambaby') }
         end
       end
 
@@ -250,6 +249,16 @@
         end
       end
 
+      describe "on osfamily Solaris" do
+        let(:facts) {{ :osfamily => 'Solaris' }}
+
+        it 'uses the NTP pool servers by default' do
+          should contain_file('/etc/inet/ntp.conf').with({
+            'content' => /server \d.pool.ntp.org/,
+          })
+        end
+      end
+
       describe "for operating system family unsupported" do
         let(:facts) {{
           :osfamily  => 'unsupported',