Clarify manage_environment_node_groups param type

The user experience should be, pass a boolean. Unfortunately there's
some ugliness in the shell script due to the boolean being passed via
environment variable and coming out the other side as a string ("true"
or "false"). For now, until we switch to Bolt apply, we're going to just
sequester this ugliness in the shell script and keep the user experience
a Boolean type.

Author: reidmv

Diff for: plans/configure.pp

@@ -13,7 +13,7 @@
   Boolean             $executing_on_primary_master = false,
 
   String[1]           $compile_master_pool_address = $primary_master_host,
-  String[1]           $manage_environment_groups = 'true',
+  Boolean             $manage_environment_groups = true,
   Optional[String[1]] $deploy_environment = undef,
 
   String[1]           $stagingdir = '/tmp',

Diff for: tasks/configure_node_groups.sh

@@ -1,5 +1,6 @@
 #!/bin/bash
 
+
 /opt/puppetlabs/bin/puppet apply --environment production <<'EOF'
 
 function param($name) { inline_template("<%= ENV['PT_${name}'] %>") }
@@ -10,7 +11,12 @@ class configure_node_groups (
   String[1]                        $puppetdb_database_host         = param('puppetdb_database_host'),
   String[1]                        $puppetdb_database_replica_host = param('puppetdb_database_replica_host'),
   String[1]                        $compile_master_pool_address    = param('compile_master_pool_address'),
+
+  # Note: the task accepts a Boolean for manage_environment_groups. Passed in
+  # as an environment variable, this will be cast to the string "true" or the
+  # string "false". Thus, the Puppet class type is Enum, rather than Boolean.
   Enum['true', 'false']            $manage_environment_groups      = param('manage_environment_groups'),
+
   Pattern[/\A[a-z0-9_]+\Z/]        $default_environment            = 'production',
   Array[Pattern[/\A[a-z0-9_]+\Z/]] $environments                   = ['production'],
 ) {