Changed default to true but not erroring out when gpg binary is not found.

Author: timidri

Diff for: tasks/download.json

@@ -12,7 +12,7 @@
     "check_download": {
       "type": "Boolean",
       "description": "Whether to check the integrity of the downloaded file",
-      "default": false
+      "default": true
     }
   },
   "input_method": "environment",

Diff for: tasks/download.sh

@@ -17,26 +17,29 @@ if [[ "$PT_check_download" != "true" ]]; then
 fi
 
 if ! which gpg ; then
-  echo "gpg binary required in path for checking download"
-  exit 1
+  echo "gpg binary required in path for checking download. Skipping check."
+  exit 0
 fi
+
 echo "Importing Puppet gpg public key"
 gpg --keyserver hkp://keyserver.ubuntu.com:11371 --recv-key 4528B6CD9E61EF26
 if gpg --list-key --fingerprint 4528B6CD9E61EF26 | grep -q -E "D681 +1ED3 +ADEE +B844 +1AF5 +AA8F +4528 +B6CD +9E61 +EF26" ; then
-  echo "gpg public key imported successfully!"
+  echo "gpg public key imported successfully."
 else
-  echo "Could not import gpg public key - wrong fingerprint"
+  echo "Could not import gpg public key - wrong fingerprint."
   exit 1
 fi
+
 sigpath=${PT_path}.asc
 sigsource=${PT_source}.asc
-echo "Downloading tarball signature from ${sigsource}"
+
+echo "Downloading tarball signature from ${sigsource}..."
 curl -f -L -o "${sigpath}" "${sigsource}"
-echo "Downloaded tarball signature to ${sigpath}"
-echo "Checking tarball signature at ${sigpath}"
+echo "Downloaded tarball signature to ${sigpath}."
+echo "Checking tarball signature at ${sigpath}..."
 if gpg --verify "${sigpath}" "${PT_path}" | grep "Good signature" ; then
   echo "Signature verification failed, please re-run the installation."
   exit 1
 else
-  echo "Signature verification suceeded!"
+  echo "Signature verification suceeded."
 fi