Lint fixes

Doing what the linter and Rubocop told me to

Author: reidmv

Diff for: spec/acceptance/peadm_spec.rb

@@ -1,15 +1,14 @@
 require 'spec_helper_acceptance'
 # @summary: default test does nothing
-def test_peadm()
-  
-    #return unless os[:family] != 'windows'
-    return unless os[:family] != 'Darwin'
+def test_peadm
+  # return unless os[:family] != 'windows'
+  return unless os[:family] != 'Darwin'
 end
 
 describe 'default' do
   context 'example acceptance do nothing' do
     it do
-        test_peadm()
+      test_peadm
     end
   end
-end
+end

Diff for: spec/spec_helper_acceptance.rb

@@ -3,4 +3,4 @@
 require 'puppet_litmus'
 require 'spec_helper_acceptance_local' if File.file?(File.join(File.dirname(__FILE__), 'spec_helper_acceptance_local.rb'))
 
-PuppetLitmus.configure!
+PuppetLitmus.configure!

Diff for: spec/spec_helper_acceptance_local.rb

@@ -8,4 +8,4 @@ class Helper
 
 def some_helper_method
   Helper.instance.bolt_run_script('path/to/file')
-end
+end

Diff for: tasks/sign_csr.rb

@@ -1,6 +1,5 @@
 #!/opt/puppetlabs/puppet/bin/ruby
 #
-# rubocop:disable Style/GlobalVars
 require 'json'
 require 'open3'
 

Diff for: tasks/submit_csr.rb

@@ -1,29 +1,26 @@
 #!/opt/puppetlabs/puppet/bin/ruby
 #
-# rubocop:disable Style/GlobalVars
 require 'json'
 require 'open3'
 
 def main
-  params = JSON.parse(STDIN.read)
-  majver = %x{/opt/puppetlabs/bin/puppet --version}
-             .chomp
-             .split('.')
-             .first
-             .to_i
+  majver = `/opt/puppetlabs/bin/puppet --version`
+           .chomp
+           .split('.')
+           .first
+           .to_i
 
   if majver < 6
-    conf = %x{/opt/puppetlabs/bin/puppet config print dns_alt_names certname}
-             .chomp
-             .split("\n")
-             .map {|line| line.split(' = ', 2) }
-             .to_h
+    conf = `/opt/puppetlabs/bin/puppet config print dns_alt_names certname`
+           .chomp
+           .split("\n")
+           .map { |line| line.split(' = ', 2) }
+           .to_h
 
     cmd = ['/opt/puppetlabs/bin/puppet', 'certificate', 'generate',
            '--ca-location', 'remote',
            '--dns-alt-names', conf['dns_alt_names'],
-           conf['certname']
-          ]
+           conf['certname']]
   else
     cmd = ['/opt/puppetlabs/bin/puppet', 'ssl', 'submit_request']
   end

Diff for: tasks/trusted_facts.rb

@@ -9,15 +9,15 @@
 ssldir = Puppet.settings[:ssldir]
 certname = Puppet.settings[:certname]
 
-oids = Puppet::SSL::Oids::PUPPET_OIDS.reduce({}) do |memo,oid|
+oids = Puppet::SSL::Oids::PUPPET_OIDS.reduce({}) do |memo, oid|
   memo.merge(oid[0] => oid[1])
 end
 
 raw = File.read("#{ssldir}/certs/#{certname}.pem")
 
 cert = OpenSSL::X509::Certificate.new(raw)
 
-extensions = cert.extensions.reduce({}) do |memo,ext|
+extensions = cert.extensions.reduce({}) do |memo, ext|
   case oids[ext.oid]
   when nil
     memo.merge(ext.oid => ext.value[2..-1])
@@ -27,6 +27,6 @@
   end
 end
 
-result = {'extensions' => extensions}
+result = { 'extensions' => extensions }
 
 puts result.to_json