Pin node_manager in metadata (#426)

* Pin WhatsARanjit/node_manager to 0.7.5 in metadata

* Pulling in module_ci workflow to override dependency check

---------

Co-authored-by: Dimitri Tischenko <[email protected]>
Co-authored-by: Neil Anderson <[email protected]>

Author: timidri

.github/workflows/ci.yml

@@ -9,7 +9,9 @@ on:
 jobs:
   Spec:
     if: ${{ github.repository_owner == 'puppetlabs' }}
-    uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@main"
+    # Temporary workaround for allowing locking node_manager less than latest
+    # uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@main"
+    uses: "./.github/workflows/module_ci.yml"
     secrets: "inherit"
 
   Acceptance:

.github/workflows/module_ci.yml

@@ -0,0 +1,92 @@
+# This is a generic workflow for Puppet module CI operations.
+name: "Module CI"
+
+on:
+  workflow_call:
+    inputs:
+      runs_on:
+        description: "The operating system used for the runner."
+        required: false
+        default: "ubuntu-latest"
+        type: "string"
+      flags:
+        description: "Additional flags to pass to matrix_from_metadata_v2."
+        required: false
+        default: ''
+        type: "string"
+
+
+jobs:
+  setup_matrix:
+    name: "Setup Test Matrix"
+    runs-on: ${{ inputs.runs_on }}
+    outputs:
+      spec_matrix: ${{ steps.get-matrix.outputs.spec_matrix }}
+
+    env:
+      BUNDLE_WITHOUT: release_prep
+
+    steps:
+
+      - name: "Checkout"
+        uses: "actions/checkout@v4"
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+
+      - name: "Setup ruby"
+        uses: "ruby/setup-ruby@v1"
+        with:
+          ruby-version: "2.7"
+          bundler-cache: true
+
+      - name: "Bundle environment"
+        run: |
+          echo ::group::bundler environment
+          bundle env
+          echo ::endgroup::
+
+      - name: Setup Spec Test Matrix
+        id: get-matrix
+        run: |
+          bundle exec matrix_from_metadata_v2 ${{ inputs.flags }}
+
+  spec:
+    name: "Spec tests (Puppet: ${{matrix.puppet_version}}, Ruby Ver: ${{matrix.ruby_version}})"
+    needs: "setup_matrix"
+    runs-on: ${{ inputs.runs_on }}
+    strategy:
+      fail-fast: false
+      matrix: ${{ fromJson( needs.setup_matrix.outputs.spec_matrix ) }}
+
+    env:
+      BUNDLE_WITHOUT: release_prep
+      PUPPET_GEM_VERSION: ${{ matrix.puppet_version }}
+      FACTER_GEM_VERSION: 'https://github.com/puppetlabs/facter#main'  # why is this set?
+
+    steps:
+      - name: "Checkout"
+        uses: "actions/checkout@v4"
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+
+      - name: "Setup ruby"
+        uses: "ruby/setup-ruby@v1"
+        with:
+          ruby-version: ${{matrix.ruby_version}}
+          bundler-cache: true
+
+      - name: "Bundle environment"
+        run: |
+          echo ::group::bundler environment
+          bundle env
+          echo ::endgroup::
+
+      - name: "Run Static & Syntax Tests"
+        run: |
+          bundle exec rake syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop
+          bundle exec dependency-checker metadata.json --override WhatsARanjit/node_manager,0.7.5
+          
+
+      - name: "Run tests"
+        run: |
+          bundle exec rake parallel_spec

.github/workflows/nightly.yml

@@ -8,7 +8,9 @@ on:
 jobs:
   Spec:
     if: ${{ github.repository_owner == 'puppetlabs' }}
-    uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@main"
+    # Temporary workaround for allowing locking node_manager less than latest
+    # uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@main"
+    uses: "./.github/workflows/module_ci.yml"
     secrets: "inherit"
 
   Acceptance:

metadata.json

@@ -14,7 +14,7 @@
     },
     {
       "name": "WhatsARanjit/node_manager",
-      "version_requirement": ">= 0.7.5 < 2.0.0"
+      "version_requirement": "0.7.5"
     },
     {
       "name": "puppetlabs/bolt_shim",