Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CentOS provisioning fails if fips-mode-setup is not installed #287

Closed
jarretlavallee opened this issue Sep 21, 2022 · 1 comment · Fixed by #289
Closed

CentOS provisioning fails if fips-mode-setup is not installed #287

jarretlavallee opened this issue Sep 21, 2022 · 1 comment · Fixed by #289

Comments

@jarretlavallee
Copy link

Describe the Bug

When provisioning an EL primary, the platform will be empty if the fips-mode-setup command is not available on the system. The task returns invalid json as seen below.

{"target":"pe-server-b2fb6c-0.us-west1-a.c.customer-support-scratchpad.internal","action":"task","object":"peadm::precheck","status":"success","value":{"_output":"/tmp/d7046e13-f606-4fc4-a0f4-980167d44dfe/precheck.sh: line 10: fips-mode-setup: command not found\r\n  {\r\n    \"hostname\": \"pe-server-b2fb6c-0.us-west1-a.c.customer-support-scratchpad.internal\",\r\n    \"platform\": \"el-7-x86_64\"\r\n  }\r\n"}}

Later on the platform is missing from the tarball.

  The task failed with exit code 1
  Downloading: https://s3.amazonaws.com/pe-builds/released/2021.7.0/puppet-enterprise-2021.7.0-.tar.gz.asc
  Downloading to temporary file /tmp/tmp.waKTPfsOK8
  Error: Curl has failed to download the file

The commit here seems to be the change that introduced the behavior. Checking for the command would get around the issue.

Expected Behavior

CentOS7 without FIPS should be able to be provisioned.

Steps to Reproduce

  1. Run the plan against a CentOS7 node without fips-mode-setup installed.
@ody
Copy link
Member

ody commented Sep 21, 2022

I'll work on this today. Was my oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants