Skip to content

Commit 334d0aa

Browse files
committed
Merge pull request #128 from wholmgren/fix-iv-doc
fix i_from_v documentation
2 parents 3a5b9a3 + 071831e commit 334d0aa

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

docs/sphinx/source/whatsnew/v0.3.0.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ Bug fixes
7373
* Fixes the import of tkinter on Python 3 (:issue:`112`)
7474
* Add a decorator to skip ``test_calcparams_desoto`` on pandas 0.18.0.
7575
(:issue:`130`)
76+
* Fixes ``i_from_v`` documentation. (:issue:`126`)
7677

7778

7879
Contributors

pvlib/pvsystem.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1227,7 +1227,7 @@ def sapm_celltemp(poa_global, wind_speed, temp_air,
12271227
'insulated_back_polymerback': [-2.81, -.0455, 0],
12281228
'open_rack_polymer_thinfilm_steel': [-3.58, -.113, 3],
12291229
'22x_concentrator_tracker': [-3.23, -.130, 13]
1230-
}
1230+
}
12311231

12321232
if isinstance(model, str):
12331233
model = temp_models[model.lower()]
@@ -1499,17 +1499,13 @@ def i_from_v(resistance_shunt, resistance_series, nNsVth, voltage,
14991499
15001500
Parameters
15011501
----------
1502-
resistance_series : float or Series
1503-
Series resistance in ohms under desired IV curve conditions.
1504-
Often abbreviated ``Rs``.
1505-
15061502
resistance_shunt : float or Series
15071503
Shunt resistance in ohms under desired IV curve conditions.
15081504
Often abbreviated ``Rsh``.
15091505
1510-
saturation_current : float or Series
1511-
Diode saturation current in amperes under desired IV curve
1512-
conditions. Often abbreviated ``I_0``.
1506+
resistance_series : float or Series
1507+
Series resistance in ohms under desired IV curve conditions.
1508+
Often abbreviated ``Rs``.
15131509
15141510
nNsVth : float or Series
15151511
The product of three components. 1) The usual diode ideal factor
@@ -1520,6 +1516,13 @@ def i_from_v(resistance_shunt, resistance_series, nNsVth, voltage,
15201516
temp_cell is the temperature of the p-n junction in Kelvin, and
15211517
q is the charge of an electron (coulombs).
15221518
1519+
voltage : float or Series
1520+
The voltage in Volts under desired IV curve conditions.
1521+
1522+
saturation_current : float or Series
1523+
Diode saturation current in amperes under desired IV curve
1524+
conditions. Often abbreviated ``I_0``.
1525+
15231526
photocurrent : float or Series
15241527
Light-generated current (photocurrent) in amperes under desired
15251528
IV curve conditions. Often abbreviated ``I_L``.

0 commit comments

Comments
 (0)